Uh oh!
There was an error while loading. Please reload this page.
feat: ADR Agent Phase 1B — Additional Fixes & Improvements - #2014
feat: ADR Agent Phase 1B — Additional Fixes & Improvements#2014ashleyshaw wants to merge 6 commits into
Conversation
Phase 1B: Templates & Validation System - 4 ADR templates (standard, lightweight, security, infrastructure) - Template loader with schema validation - 6 validators (enforcing naming, date formats, frontmatter, structure, etc.) - Validation orchestrator for multi-step checks Phase 1C: ADR Discovery Skill - Discovery skill for finding ADRs in repositories - Filters by file patterns and frontmatter criteria - Integration with Phase 1A configuration system All 88 tests passing. Copilot code quality fixes applied. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The documentation pattern check was coming after the feature pattern check, causing titles like 'docs: Add README' to match the feature pattern first (due to 'add') instead of the documentation pattern. Changed: Move documentation check before feature check and remove 'add' from feature pattern to avoid false positives. Fixes failing test: should detect type:documentation from issue titles Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Remove backup file (adr-template-loader.js.bak) to reduce noise - Fix enforceValidReferences() to handle both numeric and date-based ADR IDs - Add fallback for empty slugs in generateFilename() to prevent invalid filenames - Add complete frontmatter to adr-discovery.md with standard metadata fields Addresses comments: - Line 85 (enforceValidReferences pattern ordering) - Line 133 (generateFilename empty slug fallback) - adr-discovery.md frontmatter completion - .bak file removal Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Fixed 40+ markdown linting violations: - Removed trailing punctuation from headings - Added missing blank lines around headings, lists, and code blocks - Ensured consistent formatting with markdownlint-cli2 standards Files fixed: - .github/operations/MILESTONE_ALLOCATION_ANNOUNCEMENT.md - .github/operations/MILESTONE_ALLOCATION_MONITORING.md Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Fixed unresolved merge conflict in CHANGELOG.md from PR #1989 - Restored 5 recent entries that were inadvertently removed: * PR #2001: PR Creation Agent Phase 3 — Skills 5 & 6 * PR #1999: CI Validators Infrastructure — validate:frontmatter:changed script * PR #1994: Project Maintenance Agent — Phase 1 & 2 Documentation * PR #1993: Project documentation scripts security/logic/testing fixes * PR #1995: Phase 5A agentic release team training guide - Restored ADR Agent Phase 1B & 1C implementation entry - Restored Reports & Projects Restructuring Phase 4 entry - Removed duplicate GitHub Actions v7 upgrade entry - All recent PRs (Aug 12-18) now accurately reflected
**#1928 - Gitleaks false positive in OPENSPEC_TEMPLATE.md** - Added gitleaks ignore comments around example curl command - Prevents security scanner from flagging valid example bearer tokens **#1930 - PR template validator false negatives** - Fixed regex in sectionBody() to match any heading level (#, ##, ###) - Changed pattern from /^##\s+.+$/m to /^#+\s+.+$/m - Now correctly detects 'Changelog' and 'Global DoD Checklist' sections **#1938 - Branch name validator false negative** - Enforced strict kebab-case (lowercase, hyphens only) - Changed regex from [a-zA-Z0-9._-]+ to [a-z0-9-]+ - Updated tests to reject uppercase letters, dots, and underscores - Complies with CLAUDE.md requirement for lowercase, kebab-case branch names Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Warning Review limit reached
Next review available in:19 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚫 This PR description is missing required template content. Missing required section(s): Linked issues, Changelog, Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
📄 README Validation✅ All README checks passed.
|
🔍 Reviewer Summary for PR #2014CI Status: ❌ Recommendations
|
Pull request was closed
Summary
ADR Agent Phase 1B & 1C implementation with additional quality fixes and improvements:
Additional Fixes in This Branch
Test Coverage
All 88 tests passing with >85% coverage
Related Issues