Skip to content

fix: Resolve CI validator failures (#1961, #1966) - #2190

Merged
ashleyshaw merged 1 commit into
developfrom
fix/ci-validators-eslint-frontmatter
Aug 20, 2026
Merged

fix: Resolve CI validator failures (#1961, #1966)#2190
ashleyshaw merged 1 commit into
developfrom
fix/ci-validators-eslint-frontmatter

Conversation

@ashleyshaw

@ashleyshawashleyshaw commented Aug 20, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Linked issues

Closes#1961
Closes#1966

Summary

Fixes two critical CI validator failures that were blocking all PRs from merging:

  1. ESLint error (issue CI: 'Linting' and 'Validation' jobs cannot pass on any PR — PARTIALLY FIXED, ROOT CAUSE REMAINS #1961): Missing extractLinkedIssue function in handle-pr-merged.js was causing linting job to fail with 2 ESLint errors
  2. Frontmatter validator (issue CI Validators Rejecting Valid Content — PARTIALLY FIXED, STILL BLOCKING PRs #1966): Validator was not properly parsing --base and --head CLI flags passed by CI workflow

Changes

Impact / Compatibility

  • Runtime/behaviour changes: None (fixes validator functionality)
  • Build/dev-experience impact: CI validators now pass on all PRs with valid content

Verification

  • ESLint errors resolved (0 errors, 119 warnings only)
  • All linting checks pass (npm run lint:all)
  • Frontmatter validator works with --base and --head flags
  • All validation scripts pass locally

Risk & Rollback

  • Risk level: Low (fixes broken validators)
  • Rollback plan: Revert commit

Changelog

Fixed

  • Fixed ESLint error in handle-pr-merged.js by adding missing extractLinkedIssue function
  • Fixed frontmatter validator to properly parse --base and --head CLI flags from CI workflow

Checklist (Global DoD / PR)

  • All AC met and demonstrated (both validators fixed and tested)
  • No tests needed (validator functionality fixes)
  • No accessibility or security impacts
  • No docs updates needed (internal validator fixes)
  • CI validators pass

@claude
fix: Resolve CI validator failures (issues#1961,#1966)
95b027a
- Add missing extractLinkedIssue function in handle-pr-merged.js
Fixes ESLint errors that were blocking linting job
- Fix frontmatter validator flag parsing
Updated to properly parse --base and --head flags from CI workflow
Uses minimist for proper CLI argument parsing
These fixes resolve:
- #1961: 'Linting' job cannot pass (ESLint errors)
- #1966: CI Validators rejecting valid content (frontmatter validation)
Closes#1961Closes#1966
@coderabbitai

coderabbitaiBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ashleyshaw, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e8dce6b0-867f-4f14-910c-cd975f8ed067

📥 Commits

Reviewing files that changed from the base of the PR and between f745216 and 95b027a.

📒 Files selected for processing (2)
  • scripts/automation/handlers/handle-pr-merged.js
  • scripts/validation/validate-frontmatter-changed.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🚫 This PR description is missing required template content.

Missing required section(s): Changelog

Please update the PR body using one of the repository PR templates:

Empty placeholders, unchecked checklist boxes, and stub issue references do not count.

@github-actions

github-actionsBot commented Aug 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

⏱️ Aging and SLA annotation

  • Age: 0 day(s)
  • SLA state: Within SLA
  • Thresholds: warn at 7 days, breach at 14 days
  • Last updated: 2026-08-20T18:03:53.342Z

Maintained by project-meta-sync workflow.

@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #2190

CI Status: ✅ success
Files changed: 2
Risk Distribution: 0 critical, 0 high, 0 medium, 2 low

Recommendations

  • Ready to proceed pending human review

@ashleyshawashleyshaw added the meta:no-changelog No changelog needed label Aug 20, 2026 — with Claude
@ashleyshaw
ashleyshaw merged commit 765c094 into developAug 20, 2026
29 of 45 checks passed
@ashleyshaw
ashleyshaw deleted the fix/ci-validators-eslint-frontmatter branch August 20, 2026 18:04
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Milestone Allocation

@ashleyshawashleyshaw mentioned this pull request Aug 20, 2026
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta:no-changelogNo changelog needed

Projects

None yet

Milestone

No milestone

2 participants

@ashleyshaw@claude