fix: self-validating branch name validator for bootstrapping by ashleyshaw · Pull Request #2337 · lightspeedwp/.github

ashleyshaw · 2026-08-22T17:35:04Z

Linked issues

Relates to #1757

Summary

Resolves the bootstrapping issue where PRs that add new branch types fail validation against the old validator from the base branch. The workflow now explicitly fetches and uses the PR's version of the validator, ensuring validation happens against the rules that will actually be in effect after merge.

Changes

Modified .github/workflows/branch-name-validation.yml to add "Fetch PR version of validator" step
Workflow now validates against the rules that will be in effect after merge, not the old base rules
If PR modifies the validator, uses updated version; otherwise uses base version

Impact / Compatibility

Runtime/behaviour changes: None (validation behavior corrected to use correct ruleset)
Build/dev-experience impact: Fixes bootstrapping problem for validator modifications; future validator changes will validate correctly

Verification

CI passes
Workflow syntax validated

Risk & Rollback

Risk level: Low
Rollback plan: Revert to previous workflow version

Changelog

Fixed

Branch name validation workflow now uses PR's version of validator for self-validating checks

Checklist (Global DoD / PR)

Unified the .cjs and .js validators to enforce identical strict pattern: - Updated validate-branch-name.js to use strict pattern {type}/{scope}-{title} - Changed workflow to use .cjs (strict) instead of .js (permissive) - Updated tests to reflect strict kebab-case requirement (no dots) - Both validators now reject: release/v1.0.0, chore/release, feat/-dash-start - Both validators now accept: release/v1-0-0, feat/my-feature-with-long-name Tests: All 38 tests passing Coverage: 95% (validate-branch-name.js) This completes P1.1 of the remediation plan. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NVnti4DjcBkz59RmSWZKh

Resolves the bootstrapping issue where PRs that add new branch types (like audit/, codex/) would fail validation against the old validator from the base branch. The workflow now explicitly fetches the PR's version of the validator before validating. If the PR modifies the validator, it uses the updated rules; otherwise it uses the base version. This ensures branch names are validated against the rules that will actually be in effect after the PR merges, solving the bootstrapping problem structurally. Benefits: - Fixes the audit/validators-unified bootstrapping issue - Works for any future validator changes - Validates against semantically correct rules (what will be in effect after merge) - No special cases or exemptions needed

coderabbitai · 2026-08-22T17:35:13Z

Warning

Review limit reached

@ashleyshaw, you've reached your PR review limit, so we couldn't start this review.

Next review available in:36 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 59d9a850-1bb1-408e-858a-554cb0f09a23

📥 Commits

Reviewing files that changed from the base of the PR and between bb3cff5 and db55966.

📒 Files selected for processing (2)

.github/workflows/branch-name-validation.yml
CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-22T17:35:25Z

✅ Template check passed after update. Thanks for fixing the PR description.

Moved branch naming conventions to a more prominent position with clear "⚠️ BRANCH NAMING RULES — STRICT ENFORCEMENT" header. This makes the critical branch naming governance (including forbidden prefixes and 31 allowed types) immediately visible and impossible to miss. Changes: - Elevated branch naming rules from subsection to top-level section - Added explicit FORBIDDEN warnings for claude/, copilot/, openai/ prefixes - Clarified required format: {type}/{scope}-{short-title} - Listed all 31 allowed branch type prefixes - Added validation enforcement details Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NVnti4DjcBkz59RmSWZKh

Resolved merge conflict in .github/workflows/branch-name-validation.yml: - Kept the explanatory comment about PR validator versioning - Both branches are aligned on the core functionality - No logic changes, only comment retention Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NVnti4DjcBkz59RmSWZKh

github-actions · 2026-08-22T17:44:45Z

❌ Branch Name Validation Failed

The branch name claude/branch-naming-audit-7w84rv does not follow the LightSpeed branching strategy.

Required Format

{type}/{scope}-{short-title}

type: one of the allowed prefixes (lowercase)
scope: lowercase, hyphens only (no underscores or uppercase)
title: lowercase, hyphens only (no underscores or uppercase)

Allowed Branch Types

feat, fix, hotfix, release, refactor, chore, docs, test, perf, ci, build, deps, security, revert, research, design, a11y, ux, i18n, ops, proto, ds, api, schema, telemetry, content, seo, config, migrate, qa, uat, audit, codex

Valid Examples

✓ feat/branch-naming-enforcement
✓ fix/validation-script-bug
✓ chore/update-dependencies
✓ docs/branching-strategy-guide
✓ hotfix/critical-security-patch

Invalid Examples

✗ claude/my-branch (type "claude" not allowed)
✗ Feature/MyBranch (uppercase not allowed)
✗ fix-bug (missing type prefix)
✗ feat/my_feature (underscores not allowed)
✗ feat/MyFeature (uppercase not allowed)

Solution

Rename your branch to follow the pattern and update the PR.

For more information, see docs/BRANCHING_STRATEGY.md.

claude added 2 commits August 22, 2026 12:30

ashleyshaw marked this pull request as ready for review August 22, 2026 17:42

ashleyshaw enabled auto-merge August 22, 2026 17:43

ashleyshaw merged commit e274b76 into developAug 22, 2026
13 of 35 checks passed

ashleyshaw deleted the claude/branch-naming-audit-7w84rv branch August 22, 2026 17:44

Navigation Menu

Uh oh!

fix: self-validating branch name validator for bootstrapping - #2337

fix: self-validating branch name validator for bootstrapping#2337
ashleyshaw merged 4 commits into
developfrom
claude/branch-naming-audit-7w84rv

ashleyshaw commented Aug 22, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Aug 22, 2026•
edited
Loading

Review limit reached

Uh oh!

github-actionsBot commented Aug 22, 2026•
edited
Loading

Uh oh!

Uh oh!

github-actionsBot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ashleyshaw commented Aug 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issues

Summary

Changes

Impact / Compatibility

Verification

Risk & Rollback

Changelog

Fixed

Checklist (Global DoD / PR)

Uh oh!

coderabbitaiBot commented Aug 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actionsBot commented Aug 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 22, 2026

❌ Branch Name Validation Failed

Required Format

Allowed Branch Types

Valid Examples

Invalid Examples

Solution

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ashleyshaw commented Aug 22, 2026•
edited
Loading

coderabbitaiBot commented Aug 22, 2026•
edited
Loading

github-actionsBot commented Aug 22, 2026•
edited
Loading