Skip to content

restore: Enhance changelog agent with complete documentation and cross-references - #2350

Merged
ashleyshaw merged 3 commits into
developfrom
claude/v1-0-0-release-restore-cxic1y
Aug 26, 2026
Merged

restore: Enhance changelog agent with complete documentation and cross-references#2350
ashleyshaw merged 3 commits into
developfrom
claude/v1-0-0-release-restore-cxic1y

Conversation

@ashleyshaw

Copy link
Copy Markdown
Member
  • Add Related Files & Integration to changelog workflow
  • Verify all 10 changelog ecosystem cross-references
  • Bidirectional links between spec and portable agents
  • All agent functions and implementations present
  • Validate schema and workflow references

Changelog agent v1.0.0 production-ready for release integration

…s-references
- Add Related Files & Integration to changelog workflow
- Verify all 10 changelog ecosystem cross-references
- Bidirectional links between spec and portable agents
- All agent functions and implementations present
- Validate schema and workflow references
Changelog agent v1.0.0 production-ready for release integration
- Add file_type: agent to .github/agents/adr.agent.md
- Ensure agent spec compliance with frontmatter schema
- Preserve all existing content and metadata
Frontmatter Phase 1 partial: agent spec files updated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

⚠️ A merged PR reached develop without passing the template content guardrail.

Missing required section(s): Linked issues, Changelog, Global DoD checklist

This is a post-merge backstop for admin bypasses. Please review branch protection for develop.

@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 44 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: cbaed199-2157-4fba-995a-2a271525d5a4

📥 Commits

Reviewing files that changed from the base of the PR and between b2031c9 and e4d4898.

📒 Files selected for processing (1)
  • .github/agents/adr.agent.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d74a88c-b47e-46d3-a22a-d84a14162091

📥 Commits

Reviewing files that changed from the base of the PR and between b2031c9 and 6740dc6.

📒 Files selected for processing (2)
  • .github/agents/adr.agent.md
  • .github/workflows/changelog-management.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
⚠️ CI failures not shown inline (4)

GitHub Actions: Validate PR Template / 0_validate-pr-template.txt: restore: Enhance changelog agent with complete documentation and cross-references

Conclusion: failure

View job details

##[group]Run actions/github-script@v7
with:
script: const { validatePullRequestBody } = require('./scripts/validation/template-helpers.cjs');
const marker = '<!-- template-enforcement -->';
const pr = context.payload.pull_request;
const author = pr.user?.login || '';
const isDependabot = author === 'dependabot[bot]' || author === 'app/dependabot';
const isImgbot = author === 'imgbot[bot]' || author === 'app/imgbot';
if (isDependabot || isImgbot) {
core.info(`Skipping PR template validation for bot author ${author}.`);
return;
}
const validation = validatePullRequestBody(pr.body || '', pr.labels || [], pr.head?.ref || '');
const comments = await github.paginate(github.rest.issues.listComments, {
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pr.number,
per_page: 100
});
const previous = comments.find((comment) =>
comment.user?.type === 'Bot' && comment.body?.includes(marker)
);
if (validation.missing.length === 0) {
if (previous) {
await github.rest.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: previous.id,
body: `${marker}\n✅ Template check passed after update. Thanks for fixing the PR description.`
});
}
return;
}
const message = [
marker,
'🚫 This PR description is missing required template content.',
'',
`Missing required section(s): ${validation.missing.join(', ')}`,
'',
'Please update the PR body using one of the repository PR templates:',
'- https://github.com/lightspeedwp/.github/blob/develop/.github/pull_request_template.md',
'- https://github.com/lightspeedwp/.github/tree/develop/.github/PULL_REQUEST_TEMPLATE',
'',
'Empty placeholders, unchecked checklist boxes, and stub issue references do not count.'
].join('\n');
if (previous) {
await github.rest.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: previous.id,
body: message
});
} else {
await github.rest.issues....

GitHub Actions: Documentation Validation / 0_Validate Mermaid Diagrams.txt: fix: Add missing file_type field to ADR agent spec

Conclusion: failure

View job details

##[group]Run npm ci
�[36;1mnpm ci�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: `@mermaid-js/layout-elk`@0.2.3
npm warn Found: mermaid@10.9.8
npm warn node_modules/mermaid
npm warn dev mermaid@"^10.9.0" from the root project
npm warn 1 more (`@mermaid-js/mermaid-zenuml`)
npm warn
npm warn Could not resolve dependency:
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-elk`@0.2.3
npm warn node_modules/@mermaid-js/layout-elk
npm warn `@mermaid-js/layout-elk`@"^0.1.5 || ^0.2.0" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn
npm warn Conflicting peer dependency: mermaid@11.17.2
npm warn node_modules/mermaid
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-elk`@0.2.3
npm warn node_modules/@mermaid-js/layout-elk
npm warn `@mermaid-js/layout-elk`@"^0.1.5 || ^0.2.0" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn Found: mermaid@10.9.8
npm warn node_modules/mermaid
npm warn dev mermaid@"^10.9.0" from the root project
npm warn 1 more (`@mermaid-js/mermaid-zenuml`)
npm warn
npm warn Could not resolve dependency:
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn node_modules/@mermaid-js/layout-tidy-tree
npm warn optional `@mermaid-js/layout-tidy-tree`@"^0.2.1" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn
npm warn Conflicting peer dependency: mermaid@11.17.2
npm warn node_modules/mermaid
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn node_modules/@mermaid-js/layout-tidy-tree
npm warn optional `@mermaid-js/layout-tidy-tree`@"^0.2.1" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm error code E...

GitHub Actions: Documentation Validation / Validate Mermaid Diagrams: fix: Add missing file_type field to ADR agent spec

Conclusion: failure

View job details

##[group]Run npm ci
�[36;1mnpm ci�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: `@mermaid-js/layout-elk`@0.2.3
npm warn Found: mermaid@10.9.8
npm warn node_modules/mermaid
npm warn dev mermaid@"^10.9.0" from the root project
npm warn 1 more (`@mermaid-js/mermaid-zenuml`)
npm warn
npm warn Could not resolve dependency:
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-elk`@0.2.3
npm warn node_modules/@mermaid-js/layout-elk
npm warn `@mermaid-js/layout-elk`@"^0.1.5 || ^0.2.0" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn
npm warn Conflicting peer dependency: mermaid@11.17.2
npm warn node_modules/mermaid
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-elk`@0.2.3
npm warn node_modules/@mermaid-js/layout-elk
npm warn `@mermaid-js/layout-elk`@"^0.1.5 || ^0.2.0" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn Found: mermaid@10.9.8
npm warn node_modules/mermaid
npm warn dev mermaid@"^10.9.0" from the root project
npm warn 1 more (`@mermaid-js/mermaid-zenuml`)
npm warn
npm warn Could not resolve dependency:
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn node_modules/@mermaid-js/layout-tidy-tree
npm warn optional `@mermaid-js/layout-tidy-tree`@"^0.2.1" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm warn
npm warn Conflicting peer dependency: mermaid@11.17.2
npm warn node_modules/mermaid
npm warn peer mermaid@"^11.0.2" from `@mermaid-js/layout-tidy-tree`@0.2.2
npm warn node_modules/@mermaid-js/layout-tidy-tree
npm warn optional `@mermaid-js/layout-tidy-tree`@"^0.2.1" from `@mermaid-js/mermaid-cli`@11.16.0
npm warn node_modules/@mermaid-js/mermaid-cli
npm error code E...

GitHub Actions: Validate PR Template / validate-pr-template: restore: Enhance changelog agent with complete documentation and cross-references

Conclusion: failure

View job details

##[group]Run actions/github-script@v7
with:
script: const { validatePullRequestBody } = require('./scripts/validation/template-helpers.cjs');
const marker = '<!-- template-enforcement -->';
const pr = context.payload.pull_request;
const author = pr.user?.login || '';
const isDependabot = author === 'dependabot[bot]' || author === 'app/dependabot';
const isImgbot = author === 'imgbot[bot]' || author === 'app/imgbot';
if (isDependabot || isImgbot) {
core.info(`Skipping PR template validation for bot author ${author}.`);
return;
}
const validation = validatePullRequestBody(pr.body || '', pr.labels || [], pr.head?.ref || '');
const comments = await github.paginate(github.rest.issues.listComments, {
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pr.number,
per_page: 100
});
const previous = comments.find((comment) =>
comment.user?.type === 'Bot' && comment.body?.includes(marker)
);
if (validation.missing.length === 0) {
if (previous) {
await github.rest.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: previous.id,
body: `${marker}\n✅ Template check passed after update. Thanks for fixing the PR description.`
});
}
return;
}
const message = [
marker,
'🚫 This PR description is missing required template content.',
'',
`Missing required section(s): ${validation.missing.join(', ')}`,
'',
'Please update the PR body using one of the repository PR templates:',
'- https://github.com/lightspeedwp/.github/blob/develop/.github/pull_request_template.md',
'- https://github.com/lightspeedwp/.github/tree/develop/.github/PULL_REQUEST_TEMPLATE',
'',
'Empty placeholders, unchecked checklist boxes, and stub issue references do not count.'
].join('\n');
if (previous) {
await github.rest.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: previous.id,
body: message
});
} else {
await github.rest.issues....
🧰 Additional context used
📓 Path-based instructions (3)
Review all agent specification files:

⚙️ CodeRabbit configuration file

Files:

  • .github/agents/adr.agent.md
Review GitHub Actions workflows for this governance repo:

⚙️ CodeRabbit configuration file

Files:

  • .github/workflows/changelog-management.yml
Review agent spec and implementation files:

⚙️ CodeRabbit configuration file

Files:

  • .github/agents/adr.agent.md
🔇 Additional comments (2)
.github/agents/adr.agent.md (1)

2-2: LGTM!

.github/workflows/changelog-management.yml (1)

1-6: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated agent configuration metadata for improved identification.
    • Added workflow documentation noting related configuration and documentation files.

Walkthrough

The pull request adds agent file-type metadata and documents related files in the changelog workflow. It changes no public entities or workflow behaviour.

Changes

Repository metadata updates

Layer / File(s)Summary
Agent file classification
.github/agents/adr.agent.md
Adds file_type: agent to the ADR Generator agent front matter.
Workflow related-file documentation
.github/workflows/changelog-management.yml
Adds comments that identify related agent, script, schema, and documentation files.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk:⚪ Minimal · up to 6740d

This PR makes localized documentation and workflow-reference updates, with no actionable merge-blocking risk remaining based on the supplied evidence.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Description check⚠️ WarningThe description summarises the intended changes, but it does not use the required PR template sections. It omits linked issues, changelog entries, risk assessment, testing instructions, expected resul…Replace the current description with the appropriate routed PR template. Complete the Linked issues, Changelog, Risk Assessment, How to Test, Expected Results, Edge Cases, and Checklist sections. State clearly which items were verified and …
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly refers to the changelog agent documentation and cross-reference changes. It is slightly broader than the files changed, but it remains relevant and informative.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description summarises the intended changes, but it does not use the required PR template sections. It omits linked issues, changelog entries, risk assessment, testing instructions, expected results, edge cases, and the completion checklist.

Resolution

Replace the current description with the appropriate routed PR template. Complete the Linked issues, Changelog, Risk Assessment, How to Test, Expected Results, Edge Cases, and Checklist sections. State clearly which items were verified and provide the relevant test steps or explain why testing is not required.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch claude/v1-0-0-release-restore-cxic1y
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/v1-0-0-release-restore-cxic1y

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- Keep enhanced Related Files & Integration section from develop
- Maintain Release Agent Integration reference
- Preserve workflow logic and structure
This resolves merge conflicts between restoration branch and develop for PR #2350 merge.
@ashleyshaw
ashleyshaw merged commit 02b2f52 into developAug 26, 2026
4 of 10 checks passed
@ashleyshaw
ashleyshaw deleted the claude/v1-0-0-release-restore-cxic1y branch August 26, 2026 22:31
@github-actions

Copy link
Copy Markdown
Contributor

❌ Branch Name Validation Failed

The branch name claude/v1-0-0-release-restore-cxic1y does not follow the LightSpeed branching strategy.

Required Format

{type}/{scope}-{short-title}
  • type: one of the allowed prefixes (lowercase)
  • scope: lowercase, hyphens only (no underscores or uppercase)
  • title: lowercase, hyphens only (no underscores or uppercase)

Allowed Branch Types

feat, fix, hotfix, release, refactor, chore, docs, test, perf, ci, build, deps, security, revert, research, design, a11y, ux, i18n, ops, proto, ds, api, schema, telemetry, content, seo, config, migrate, qa, uat, audit, codex

Valid Examples

  • feat/branch-naming-enforcement
  • fix/validation-script-bug
  • chore/update-dependencies
  • docs/branching-strategy-guide
  • hotfix/critical-security-patch

Invalid Examples

  • claude/my-branch (type "claude" not allowed)
  • Feature/MyBranch (uppercase not allowed)
  • fix-bug (missing type prefix)
  • feat/my_feature (underscores not allowed)
  • feat/MyFeature (uppercase not allowed)

Solution

Rename your branch to follow the pattern and update the PR.

For more information, see docs/BRANCHING_STRATEGY.md.

@github-actions

Copy link
Copy Markdown
Contributor

Milestone Allocation

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #2350

CI Status:success
Files changed: 1
Risk Distribution: 0 critical, 1 high, 0 medium, 0 low

Recommendations

  • Ready to proceed pending human review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ashleyshaw@claude