Uh oh!
There was an error while loading. Please reload this page.
fix(workflows): least-privilege permissions; catch remaining stale action versions - #2356
Conversation
…tch repo-wide action version stragglers
Adds explicit least-privilege `permissions:` to the 6 workflows that had
none at all (workflow- or job-level): changelog.yml, flaky-test-detection.yml,
linting.yml, testing.yml (contents: read only), pr-template-validation.yml
(permissions: {} — no checkout, no API writes), and meta-agent-validation.yml
(contents: read + pull-requests: write, for its PR comment steps). Scoped by
reading each job's actual steps rather than assuming. The other 12 workflows
flagged earlier already had correctly-scoped job-level permissions blocks
(just not at workflow level), so were left untouched.
Also fixes the previous action-version-bump pass (#2355), which only covered
.github/workflows/ and missed the top-level workflows/, agents/*/skills/,
and skills/ directories — 10 more files still pinned to actions/github-script@v7
(the specific staleness the CI annotation on #2351 flagged after Node 20
runner deprecation). Repo-wide grep now confirms every action reference
resolves to its actual current release, verified via the GitHub API.Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
🚫 This PR description is missing required template content. Missing required section(s): Linked issues, Changelog, Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
Merge Queue Status
This pull request spent 11 seconds in the queue, including 2 seconds running CI. Required conditions to merge |
Uh oh!
There was an error while loading. Please reload this page.
Milestone Allocation |
Summary
Follow-up to #2355 (merged). Targets #2351 (release/v1.0.0).
Missed scope in #2355: that PR only bumped action versions under
.github/workflows/. Repo-wide grep found 10 more workflow-shaped files still pinned to old majors —workflows/*.yml(the top-level "portable agentic workflows" folder), anddesign-md-lint.ymlunderagents/*/skills/andskills/. This is what PR #2351's CI annotation was flagging (actions/github-script@v7forced onto the deprecated Node 20 runner). All bumped to@v9, verified against the GitHub API — no stragglers remain repo-wide (checked viagrep -rhoPacross every.yml/.yaml).Least-privilege permissions, the item flagged in the original review and deferred:
changelog.yml,flaky-test-detection.yml,linting.yml,testing.yml— none of these write to the repo or call the GitHub API; addedpermissions: contents: read.pr-template-validation.yml— no checkout, no API calls at all (only readscontext.payload.pull_request.bodyviagithub-script); setpermissions: {}.meta-agent-validation.yml— has twogithub.rest.issues.createCommentcalls onpull_request; addedcontents: read+pull-requests: write.badges-*,docs-validation.yml,issue-health-audit.yml,issue-labeling-automation.yml,issue-remediation-automation.yml,metrics-collection.yml,validate-dor-dod-sections.yml,validate-mermaid-pr.yml) already had correctly-scoped job-levelpermissions:blocks — my first pass'sgrep "^permissions:"only checked column 0 and missed those. Verified each still matches what its steps actually need; left untouched.Test plan
validate-pr-template(should stop flagging Node 20/github-script@v7)meta-agent-validation.yml's PR-comment step still succeeds withpull-requests: write(was previously running with whatever the org/repo default token permissions grant)