Skip to content

fix(workflows): actually match main's required check name this time - #2364

Merged
eleshar merged 1 commit into
release/v1.0.0from
fix/main-branch-guard-job-name-v2
Aug 27, 2026
Merged

fix(workflows): actually match main's required check name this time#2364
eleshar merged 1 commit into
release/v1.0.0from
fix/main-branch-guard-job-name-v2

Conversation

@eleshar

Copy link
Copy Markdown
Contributor

Linked issues

Relates to #2351, follow-up to #2363 which didn't actually fix the problem.

Changelog

Fixed

Risk Assessment

Risk Level: Low

Potential Impact: Only changes the reported check-run name, no change to validation logic.

Mitigation Steps: Verified locally that the resulting YAML is valid before pushing.

How to Test / Test Plan

Confirm via the GitHub API that the check-run name on the next PR against main is exactly Main Branch Guard / validate-release-branch, and that #2351's mergeStateStatus clears to CLEAN.

Checklist (Global DoD / PR)

  • Confirmed the previous attempt's failure via API before writing this fix
  • YAML validity checked locally

The previous fix (removing the name: override) didn't work: the
override was literally "validate-release-branch", identical to the
job's own id, so removing it changed nothing — GitHub still reported
the check as "validate-release-branch" because that's what it uses
by default for a plain job with no matching workflow-name-prefix
behavior. Confirmed post-merge via the GitHub API that the check-run
name was unchanged.
Sets name: explicitly to the literal string branch protection
actually requires: "Main Branch Guard / validate-release-branch".
@coderabbitai

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)
  • main
  • develop
  • feature/*
  • fix/*
  • update/*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 828fa0cf-460c-4171-a22e-56af5cd9b211

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized keys: "auto_labels", "auto_assign", "auto_review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eleshar
eleshar merged commit be50427 into release/v1.0.0Aug 27, 2026
4 of 9 checks passed
@eleshar
eleshar deleted the fix/main-branch-guard-job-name-v2 branch August 27, 2026 13:21
@github-actions

Copy link
Copy Markdown
Contributor

Milestone Allocation

@github-actions

Copy link
Copy Markdown
Contributor

❌ Branch Name Validation Failed

The branch name fix/main-branch-guard-job-name-v2 does not follow the LightSpeed branching strategy.

Required Format

{type}/{scope}-{short-title}
  • type: one of the allowed prefixes (lowercase)
  • scope: lowercase, hyphens only (no underscores or uppercase)
  • title: lowercase, hyphens only (no underscores or uppercase)

Allowed Branch Types

feat, fix, hotfix, release, refactor, chore, docs, test, perf, ci, build, deps, security, revert, research, design, a11y, ux, i18n, ops, proto, ds, api, schema, telemetry, content, seo, config, migrate, qa, uat, audit, codex

Valid Examples

  • feat/branch-naming-enforcement
  • fix/validation-script-bug
  • chore/update-dependencies
  • docs/branching-strategy-guide
  • hotfix/critical-security-patch

Invalid Examples

  • claude/my-branch (type "claude" not allowed)
  • Feature/MyBranch (uppercase not allowed)
  • fix-bug (missing type prefix)
  • feat/my_feature (underscores not allowed)
  • feat/MyFeature (uppercase not allowed)

Solution

Rename your branch to follow the pattern and update the PR.

For more information, see docs/BRANCHING_STRATEGY.md.

@eleshareleshar mentioned this pull request Aug 27, 2026
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@eleshar