Uh oh!
There was an error while loading. Please reload this page.
Enforce PR labeling requirement - all PRs must have labels - #2438
Open
ashleyshaw wants to merge 5 commits into
Open
Enforce PR labeling requirement - all PRs must have labels#2438ashleyshaw wants to merge 5 commits into
ashleyshaw wants to merge 5 commits into
Conversation
…abels Implement strict enforcement of PR labeling requirements: 1. Add validation that all PRs must have at least one label from required categories (type:*, area:*, priority:*, meta:*) 2. Auto-label release/hotfix branches with type:release 3. Block PR merge if labels are missing with clear error message 4. Fetch current PR state from API to validate updated labels after auto-labeling Changes: - .github/labeler.yml: Add type:release rule for release/* and hotfix/* branches - .github/workflows/labeling-governance.yml: Add strict validation check that fetches current PR labels from API and fails if no valid labels found This ensures PR #2351 (v1.0.0 release) and all future PRs comply with labeling governance. Closes#2352 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmQfEJJ8xPNypW14ii1cwz
Contributor
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Template check passed after update. Thanks for fixing the PR description. |
- Remove hotfix/* from type:bug rule to avoid conflict with type:release - Keep hotfix/* only in type:release and priority:critical rules - Fix GitHub Actions expression interpolation issue in workflow script - Update PR template to include all required sections
- Change core.setOutput from 'conclusion' to 'status' to match the enforce step's condition - Fixes the enforce labeling requirement step condition that checks steps.check.outputs.status
ashleyshaw
marked this pull request as ready for review
August 28, 2026 15:03
Contributor
Tick the box to add this pull request to the merge queue (same as
|
ashleyshaw pushed a commit
that referenced
this pull request
Aug 29, 2026
**Issue #2423 - Auto-regenerate Documentation workflow failure:** - Added missing npm scripts that documentation.yml workflow depends on: - validate:mermaid-syntax - validate:mermaid-accessibility - validate:mermaid-contrast - audit:readme (placeholder) - Discovered that the actual validation scripts exist in scripts/validation/ - Now the documentation workflow can execute properly without "script not found" errors **Impact:** - Unblocks PR #2438 and issue #2352 work - Documentation workflow can now run mermaid validation checks - Existing validation script failures are separate concerns to be addressed Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016r1hTKjqfSatLWXCTWuxdE
6 tasks
ashleyshaw
enabled auto-merge
August 29, 2026 02:27
…check job The labeling-check job posts comments on the PR when validation fails, which requires issues:write permission. Without it, comment operations will fail silently or be denied.
Contributor
🔍 Reviewer Summary for PR #2438CI Status: ✅ Recommendations
|
The js-yaml package does not provide a default export in the current version.
Changed all imports from 'import yaml from "js-yaml"' to 'import { load } from "js-yaml"'
and updated all usages of yaml.load() to load().
This fixes CI failures across validation, labeling, and metadata agents.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KmQfEJJ8xPNypW14ii1cwz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Closes#2352
Changelog
Changed
type:releaseauto-labeling rule forrelease/*andhotfix/*branches in.github/labeler.ymllabeling-governance.ymlworkflowAdded
Risk Assessment
Risk Level: Low
Potential Impact:
Mitigation Steps:
How to Test
Prerequisites
Test Steps
Test release branch auto-labeling:
release/v1.0.0branch targetingdeveloptype:releaselabel is automatically appliedtype:releaselabelTest hotfix branch auto-labeling:
hotfix/urgent-fixbranch targetingdeveloptype:releaselabel is automatically appliedtype:releaselabelTest normal branch type detection:
feat/,fix/,chore/, etc.type:feature,type:bug,type:chore)Test validation enforcement:
Expected Results
type:releasetype:*labelsEdge Cases to Verify
Checklist (Global DoD / PR)
References