Uh oh!
There was an error while loading. Please reload this page.
build(deps-dev): bump @types/node from 20.19.43 to 24.13.3 - #46
Merged
Conversation
Dependabot proposed 26.1.2 (#44). It type-checks and builds, but it types the build against a Node newer than the one we actually run: www.yml pins `node-version: 24`. Types ahead of the runtime is the wrong direction of skew — it lets a call to a Node 26 API pass tsc and then fail in CI, which is the one failure mode this package exists to prevent. 24.13.3 matches the runtime. The 20 -> 24 move is still the substance of the bump; 20 has been out of support since April 2026. Verified on both: `tsc --noEmit` clean and a full `opennextjs-cloudflare build` succeeds under 24 and under 26 — the choice is about which runtime we want the type-checker to model, not about anything being broken. If you'd rather track latest, the coherent version of that is bumping www.yml's node-version and @types/node together; happy to do that instead. Closes#44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Dependabot's #44, which went to 26.1.2.
Both versions work — I checked.
tsc --noEmitis clean andopennextjs-cloudflare buildsucceeds under 24 and 26. So this isn't a fix, it's a choice about which runtime the type-checker should model.www.ymlpinsnode-version: 24. Typing the build against Node 26 while running Node 24 is skew in the wrong direction: a call to a Node 26 API would passtsclocally and fail at build time in CI. Matching the types to the runtime is the boring, defensible default.The substance of the bump — off
@types/node@20, which has been out of support since April 2026 — is unchanged.If you'd rather track latest, the coherent way to do that is bumping
www.yml'snode-versionand@types/nodein the same change. Say the word and I'll do that version instead.Verification
Same caveat as #45: CI checks nothing here until #38 lands (
www.ymlhas nopull_requesttrigger).Closes#44