fix: remove invalid locale test that passes unexpectedly by cherkanovart · Pull Request #8 · lingodotdev/sdk-python

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cherkanovart · 2026-02-06T14:12:43Z

Summary

Removed test_error_handling_invalid_locale from integration tests
The test expected an exception for invalid source locales, but the API handles them gracefully without raising errors, making the test unreliable

Test plan

Verified all remaining integration tests still pass
Confirmed SDK works correctly via manual test project covering all 12 documented features

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Adjusted test suite coverage for error handling validation.

The test_error_handling_invalid_locale test expected an exception for invalid source locales, but the API handles this gracefully without raising an error, making the test unreliable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-02-06T14:13:11Z

📝 Walkthrough

Walkthrough

A test method validating error handling for invalid source locales was removed from the integration test suite. The error-handling logic itself remains unchanged; only the test exercising that path was removed.

Changes

Cohort / File(s)	Summary
Test Removal `tests/test_integration.py`	Removed `test_error_handling_invalid_locale` method from `TestRealAPIIntegration` class, eliminating test coverage for invalid source locale error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 One test bids farewell to the suite so bright,
Locale checking fades from sight,
The error path still stands so strong,
Just less coverage along the way—
Leaner tests greet a cleaner day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a test that unexpectedly passes due to API behavior diverging from test expectations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-invalid-locale-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vrcprl approved these changes Feb 6, 2026
View reviewed changes

cherkanovart merged commit a6ca7da into mainFeb 6, 2026
6 checks passed