Uh oh!
There was an error while loading. Please reload this page.
Add Kinesis streams link - #53
Closed
t0mas wants to merge 1 commit into
Closed
Conversation
fxkr
requested changes
Mar 12, 2024
fxkr
left a comment
Member
There was a problem hiding this comment.
Thank you very much for the contribution. I have left two code review comments.
| }, | ||
| "kinesis": { // Amazon Kinesis | ||
| "stream": null, | ||
| "stream": () => `https://${this.region}.console.aws.amazon.com/kinesis/home?region=${this.region}#/streams/details/${this.resource}/details`, |
Member
There was a problem hiding this comment.
Can you add a unit test case to cover this change? You can see examples here: https://github.com/link2aws/link2aws.github.io/blob/master/testcases/aws.json
| } | ||
| exports.ARN = ARN; No newline at end of file | ||
| exports.ARN = ARN; |
Member
There was a problem hiding this comment.
Can you remove the unnecessary whitespace change?
fxkr
commented
Mar 1, 2026
Member
Implemented in #75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add console link for Kinesis streams