Skip to content

Propagate exclude credential - #213

Merged
iinuwa merged 5 commits into
mainfrom
propagate-exclude-credential
Aug 27, 2026
Merged

Propagate exclude credential#213
iinuwa merged 5 commits into
mainfrom
propagate-exclude-credential

Conversation

@iinuwa

@iinuwaiinuwa commented Aug 22, 2026

Copy link
Copy Markdown
Member

Fixes#211.

This is going to conflict with #204 though, so I'll wait until that lands to merge this.

Fixes#214 also.

msirringhaus
msirringhaus previously approved these changes Aug 24, 2026

@msirringhausmsirringhaus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iinuwa
iinuwaforce-pushed the propagate-exclude-credential branch from ad52d2e to d1b627fCompareAugust 26, 2026 05:31
@iinuwa

Copy link
Copy Markdown
MemberAuthor

Rebased, so this is a bit smaller now. I tested and this works to return to the error to the caller, but there's a follow-up needed from #204 to prevent sending a ErrorCancelled error right after the CredentialExcluded to the UI, so the window flashes from "This authenticator is already registered" to "Something went wrong."

Still need to add tests before merging

@iinuwaiinuwa added this to the 0.3 milestone Aug 26, 2026
@iinuwa

Copy link
Copy Markdown
MemberAuthor

I modified the tests introduced to allow modeling a handler that can send events after receiving cancellation, which caused some tests to fail, and then made the *Stream structs aware of the cancellation token to fix it. Now Credential Excluded error shows up in the UI correctly.

I'm going to go ahead and merge this and start working on tagging 0.3.

@iinuwa
iinuwa merged commit 25dbac2 into mainAug 27, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't send cancellation after success Return InvalidStateError to caller

2 participants

@iinuwa@msirringhaus