Uh oh!
There was an error while loading. Please reload this page.
client: support already-derived file keys - #559
Merged
bilelmoussaoui merged 4 commits intoAug 25, 2026
Conversation
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
caniko
commented
Aug 25, 2026
ContributorAuthor
Addressed the five review comments in |
Uh oh!
There was an error while loading. Please reload this page.
bilelmoussaoui
commented
Aug 25, 2026
Collaborator
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add file-backend APIs for callers that already hold derived key material:
LockedKeyring::{validate_key, unlock_with_key}UnlockedKeyring::{load_with_key, open_with_key, open_at_with_key}This also makes
oo7::Keypublicly nameable for those APIs.Behavior
Keys are checked against the active crypto backend's required key length before use.
validate_keymirrorsvalidate_secret: it returns true for an empty keyring or when at least one item authenticates.unlock_with_keyretains the existing corruption thresholds, so a partially corrupted keyring can validate but still returnPartiallyCorruptedKeyring.Non-empty unencrypted keyrings reject a direct key. Key-based
openandopen_atoperate only on v1 paths and do not inspect or migrate v0 files; secret-based open retains legacy migration.An exact-length
Key::new(...)value is treated as caller-supplied direct key material, so the caller is responsible for its entropy.Scope
This PR does not add restart state, fdstore transport, PAM or server changes, D-Bus readiness changes, migration recovery, a generic credential provider, or an unchecked key API.
Testing
Tested with both crypto backends, the complete Tokio client suites, async-std builds, workspace checks and clippy, rustfmt, rustdoc, cargo-deny, and the affected server and package builds. A disposable external async-std consumer also exercised key-only read, write, reload, and wrong-key rejection with both crypto backends without Tokio or
oo7-daemonin its feature graph.Refs #548.