Uh oh!
There was an error while loading. Please reload this page.
feat(xai): support session-managed STT keyterms - #6652
Open
u9g wants to merge 2 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
transcript.done also ends the utterance, so the deferred keyterm reconnect must fire there too; otherwise pending session keyterms are dropped whenever an utterance terminates without speech_final.
longcw
reviewed
Aug 4, 2026
| self._opts.smart_turn_timeout = smart_turn_timeout | ||
| if is_given(keyterm): | ||
| self._user_keyterms = _validate_user_keyterms(keyterm) |
Contributor
There was a problem hiding this comment.
move this validation to the top so the options are not partially updated?
| valid_session_keyterms: list[str] = [] | ||
| invalid_count = 0 | ||
| for term in session_keyterms: | ||
| if len(term) > _MAX_KEYTERM_LENGTH: |
Contributor
There was a problem hiding this comment.
this truncates the newest detected terms, we should drop the oldest instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6587, which exposed the raw xAI
keytermWebSocket option.Validation
pytest --plugin xai(6 passed)ruff format --checkandruff checkon changed files