Tests for withDeadline - #925
Merged
Merged
Conversation
|
Contributor
|
Diffuse output: AAR |
6 tasks
5 tasks
xianshijing-lk
added a commit
that referenced
this pull request
Sep 14, 2026
TrackBitrateInfo and TrackBitrateInfoKey were public only so the separate test module could reach them. friendPaths (#925) made that unnecessary, so mark them internal along with the two-arg ensureCodecBitrates that exposes them. Both were already @Suppress'd and only reachable through a @VisibleForTesting helper, so this is not intended API. Compiled signatures are unchanged; internal is recorded in @metadata only. Document isScreenShare and the kbps unit on TrackBitrateInfo, and record why the start bitrate is written once to every video m-section: libwebrtc pushes these codec fmtp params into the shared Call, retains start_bitrate_bps in RtpBitrateConfigurator, and re-applies it on network route changes, so rewriting it later either no-ops or restarts a converged estimator. Same for why x-google-max-bitrate is never written. Add the changeset, including the max-bitrate removal as a behavior change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.