Skip to content

Tests for withDeadline - #925

Merged
davidliu merged 1 commit into
mainfrom
dl/withDeadlineTests
May 5, 2026
Merged

davidliu merged 1 commit into
mainfrom
dl/withDeadlineTests

Conversation

@davidliu

@davidliu davidliu commented May 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c76f5af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: diffuse-source-file
NEW: livekit-android-sdk-release.aar

 AAR      │ old      │ new      │ diff 
──────────┼──────────┼──────────┼──────
      jar │    4 MiB │    4 MiB │  0 B 
 manifest │  1.5 KiB │  1.5 KiB │  0 B 
 lint-jar │ 12.7 KiB │ 12.7 KiB │  0 B 
    other │  1.8 KiB │  1.8 KiB │  0 B 
──────────┼──────────┼──────────┼──────
    total │    4 MiB │    4 MiB │  0 B 

 JAR     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
 classes │  2214 │  2214 │ 0 (+0 -0) 
 methods │ 42989 │ 42989 │ 0 (+0 -0) 
  fields │  8397 │  8397 │ 0 (+0 -0)
AAR
 size │ diff │ path    
──────┼──────┼─────────
  0 B │  0 B │ (total)

@davidliu
davidliu merged commit 8c3e667 into main May 5, 2026
6 checks passed
@davidliu
davidliu deleted the dl/withDeadlineTests branch May 5, 2026 16:13
xianshijing-lk added a commit that referenced this pull request Sep 14, 2026
TrackBitrateInfo and TrackBitrateInfoKey were public only so the separate
test module could reach them. friendPaths (#925) made that unnecessary, so
mark them internal along with the two-arg ensureCodecBitrates that exposes
them. Both were already @Suppress'd and only reachable through a
@VisibleForTesting helper, so this is not intended API. Compiled signatures
are unchanged; internal is recorded in @metadata only.

Document isScreenShare and the kbps unit on TrackBitrateInfo, and record why
the start bitrate is written once to every video m-section: libwebrtc pushes
these codec fmtp params into the shared Call, retains start_bitrate_bps in
RtpBitrateConfigurator, and re-applies it on network route changes, so
rewriting it later either no-ops or restarts a converged estimator. Same for
why x-google-max-bitrate is never written.

Add the changeset, including the max-bitrate removal as a behavior change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant