fix: Properly handle broadcast capture state - #705
Merged
Conversation
Mirrors API of the same class from the native Swift SDK.
Unneeded functionality has been omitted.
This is necesary to allow using the Combine framework. Since the minimum deployment target is iOS 13 according to the Podspec, this should not cause any issues.
Same solution as implemented in PR livekit#551 for the native Swift SDK.
Sets the `deviceId` constraint to `broadcast-manual`, ensuring the broadcast picker isn't presented a second time when publishing a screen share track.
Removes boilerplate for iOS broadcast state management now handled internally by the library.
ladvoc
marked this pull request as draft
February 12, 2025 02:36
ladvoc
marked this pull request as ready for review
February 12, 2025 18:59
Contributor
|
The corresponding flutter-webrtc has been released |
Contributor
|
hey @ladvoc, There is a small issue preventing CI from passing, can you try running |
Contributor
|
I noticed that there is no place where BroadcastManager.requestStop is called. This causes the iOS system to remain in the recording state when screen sharing is disabled, and the next time screen sharing is enabled, an exception will occur. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
BroadcastManagerclass gives developers control over the broadcast state and track publication for advanced use cases.Fixes
Minor breaking changes
setScreenShareEnabledorsetSourceEnabledon LocalParticipant currently returns a LocalTrackPublication representing the newly published screen share track. After this change, when using the broadcast capturer on iOS, this method will return null, as the track will be published asynchronously pending user approval. Developers should treat enabling screen share as a request that might not be fulfilled and should not interpret null return values from these methods as errors.setSourceEnabledwhen enabling screen sharing.Additional context
Outstanding items