Skip to content

fix(uniffi): publish livekit_datatrack.swift with the Swift package #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pblazej merged 1 commit into from
Aug 6, 2026
Merged

fix(uniffi): publish livekit_datatrack.swift with the Swift package #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/uniffi-swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
${{ env.OUTPUT_DIR }}/LICENSE:LICENSE
${{ env.OUTPUT_DIR }}/PrivacyInfo.xcprivacy:PrivacyInfo.xcprivacy
${{ env.OUTPUT_DIR }}/Sources/${{ env.SPM_NAME }}/livekit_uniffi.swift:Sources/${{ env.SPM_NAME }}/livekit_uniffi.swift
${{ env.OUTPUT_DIR }}/Sources/${{ env.SPM_NAME }}/livekit_datatrack.swift:Sources/${{ env.SPM_NAME }}/livekit_datatrack.swift

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Release notes entry missing for this fix

The change ships without the required release-notes entry (no file added under /.changeset alongside the workflow edit at .github/workflows/uniffi-swift.yml:100), so the fix will not appear in the generated changelog or trigger a package bump.
Impact: Users reading the release notes won't see that the broken Swift package was fixed, and no new version may be published to deliver it.

Repository rule requiring a changeset per PR

AGENTS.md ("Documenting changes") states: "Every PR needs a changeset" and "Changeset must list any crates which need to be bumped stemming from the change". A comparable CI-only fix (commit 00258d1e, PR #1300) touching the same workflow added .changeset/fix_uniffi_android_package_build.md. This PR only modifies .github/workflows/uniffi-swift.yml with no changeset file, and the repo has a CI check for changeset detection (see commits 97c18fa6, a7a26250).

Prompt for agents 
AGENTS.md requires every PR to include a knope changeset under /.changeset, listing the crates that need bumping. This PR fixes the Swift package publish step in .github/workflows/uniffi-swift.yml but adds no changeset, and precedent (PR #1300, commit 00258d1e) shows even CI-only uniffi fixes include one so a new livekit-uniffi version is cut and the fix reaches published packages. Add a changeset (e.g., via `knope document-change`) describing the missing livekit_datatrack.swift bindings fix and the affected package.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@pblazej pblazej Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed manually in the spm repo for now.

token: ${{ secrets.UNIFFI_XCFRAMEWORK_PAT }}
pr-body: |
Source tag: `${{ inputs.tag_name }}`
Expand Down
Loading