Skip to content

Require single-line plain-text changeset summaries - #1411

Merged
1egoman merged 1 commit into
mainfrom
fix-changeset-formatting
Sep 8, 2026
Merged

1egoman merged 1 commit into
mainfrom
fix-changeset-formatting

Conversation

@1egoman

@1egoman 1egoman commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The release page formatting is inconsistient - some entries are changelog bullets, others are #### headings followed by further markdown.

That is knope's rendering rule, not a knope bug. A changeset whose summary is one line becomes a bullet:

- Add data streams v2 to exposed uniffi interface - #1286 (@1egoman)

A summary spanning more than one line is promoted to a heading, with everything after the first line dropped below it as loose body text:

#### Moves the signalling client into a new `livekit-signaling` crate. livekit-api

re-exports it under the historical `livekit_api::signal_client` path, now marked
deprecated: ...

Markdown blocks (tables, bullet lists, bold-led paragraphs) guarantee this, and they keep showing up in agent-written changesets — but a plain hard line wrap is enough on its own. The changeset for #1406 was plain text wrapped at 80 columns and still rendered as #### Add agent guidance for detecting and preventing memory-lifecycle regressions in.

So this adds a rule under Documenting changes in AGENTS.md: write the changeset summary as a single unwrapped line of plain prose, no Markdown blocks (inline backticks are fine — they render correctly), and keep detail in the PR description instead.

knope renders a one-line changeset summary as a changelog bullet, but
promotes anything longer to a `####` heading with the remainder stranded
below it as loose body text. The release page ends up as a mix of the two.

A hard line wrap is enough to trigger it on its own — the changeset for
#1406 was plain text wrapped at 80 columns and still rendered as
`#### Add agent guidance for detecting and preventing memory-lifecycle
regressions in` — but Markdown blocks (tables, bullet lists, bold-led
paragraphs) guarantee it, and those keep showing up in agent-written
changesets.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@1egoman
1egoman requested a review from ladvoc as a code owner September 8, 2026 19:31

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@1egoman
1egoman merged commit 20ac261 into main Sep 8, 2026
8 checks passed
@1egoman
1egoman deleted the fix-changeset-formatting branch September 8, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants