Skip to content

ci: improved ffi builds - #156

Merged
theomonnom merged 3 commits into
livekit:mainfrom
theomonnom:main
Aug 16, 2023
Merged

theomonnom merged 3 commits into
livekit:mainfrom
theomonnom:main

Conversation

@theomonnom

@theomonnom theomonnom commented Aug 16, 2023

Copy link
Copy Markdown
Member
  • explicit deployment target for macos
  • better library naming
  • use manylinux (increase linux compatibility). good practice from the Python community
    • currently using manylinux2014

related PR was #147 but it was not sufficient

@theomonnom
theomonnom requested a review from davidzhao August 16, 2023 02:27

@davidzhao davidzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theomonnom
theomonnom merged commit 943cf97 into livekit:main Aug 16, 2023
hiroshihorie added a commit that referenced this pull request Sep 1, 2026
The multi-crate codegen fixes (Uniffi-Dart/uniffi-dart#150, #154, #156)
are all merged upstream, so the temporary pin to the contributor fork is
no longer needed. Pin the current upstream main rev, as no release tag
has been cut since v0.2.1.

Upstream codegen now emits ignore_for_file hints and drops unused
imports, but it introduces unused locals in async callback trampolines,
so add unused_local_variable to the generated-code lint ignores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants