add livekit_ffi_dispose - #453
Merged
Merged
Conversation
keepingitneil
approved these changes
Oct 2, 2024
jhugman
added a commit
that referenced
this pull request
Sep 1, 2026
Generates NAPI TypeScript bindings from any compiled uniffi cdylib, so it sits alongside the uniffi-bindgen already here rather than being vendored into one crate's build. `default-features = false` is load-bearing, not tidiness: ubrn's `wasm` feature pulls wasm-bindgen-cli-support, which `=`-pins the wasm-bindgen family to its own version — unsatisfiable against the wasm-bindgen this workspace resolves through livekit -> libwebrtc. Pinned by commit rather than tag: this is the released line's main, which carries #453 — without it a non-wasm build silently generates JSI bindings instead of NAPI, exit 0 and no warning. Move to a tag when one ships past 0.31.0-5. A `rev` also keeps `cargo update` from sweeping the generator forward on its own, since what it emits has to stay in step with the @ubjs/* runtime it imports.
jhugman
added a commit
that referenced
this pull request
Sep 1, 2026
Generates NAPI TypeScript bindings from any compiled uniffi cdylib, so it sits alongside the uniffi-bindgen already here rather than being vendored into one crate's build. `default-features = false` is load-bearing, not tidiness: ubrn's `wasm` feature pulls wasm-bindgen-cli-support, which `=`-pins the wasm-bindgen family to its own version — unsatisfiable against the wasm-bindgen this workspace resolves through livekit -> libwebrtc. Pinned by commit rather than tag: this is the released line's main, which carries #453 — without it a non-wasm build silently generates JSI bindings instead of NAPI, exit 0 and no warning. Move to a tag when one ships past 0.31.0-5. A `rev` also keeps `cargo update` from sweeping the generator forward on its own, since what it emits has to stay in step with the @ubjs/* runtime it imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.