[lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan by medismailben · Pull Request #70392 · llvm/llvm-project

medismailben · 2023-10-26T23:31:16Z

This patch makes ScriptedThreadPlan conforming to the ScriptedInterface
& ScriptedPythonInterface facilities by introducing 2
ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes.

This allows us to get rid of every ScriptedThreadPlan-specific SWIG
method and re-use the same affordances as other scripting offordances,
like Scripted{Process,Thread,Platform} & OperatingSystem.

To do so, this adds new transformer methods for ThreadPlan, Stream &
Event, to allow the bijection between C++ objects and their python
counterparts.

bulbazord

I think all of my comments have been addressed. Thanks!

JDevlieghere

LGTM with a few nits. This looks really great with the new interfaces.

This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…eadPlan (#70392)" This reverts commit 4b3cd37 since it introduces some test failures: https://lab.llvm.org/buildbot/#/builders/68/builds/62556

medismailben · 2023-10-31T00:42:29Z

This has been reverted in 6eafe2c since it introduced some test failures:

Failed Tests (4):
lldb-api :: functionalities/completion/TestCompletion.py
lldb-api :: functionalities/step_scripted/TestStepScripted.py
lldb-api :: functionalities/thread_plan/TestThreadPlanCommands.py
lldb-shell :: Commands/command-stop-hook-output.test

DavidSpickett · 2023-11-03T10:24:50Z

So in case it was confusing, the revert did fix Arm 32 bit linux as well, but it stayed red for other reasons.

Also I looked into it on the same machine and got:

********************
Unresolved Tests (1):
  lldb-api :: functionalities/thread_plan/TestThreadPlanCommands.py

********************
Failed Tests (3):
  lldb-api :: functionalities/completion/TestCompletion.py
  lldb-api :: functionalities/step_scripted/TestStepScripted.py
  lldb-shell :: Commands/command-stop-hook-output.test

Same tests as on x86. One failed with:

FAIL: LLDB (/home/david.spickett/build-arm/bin/clang-arm) :: test_thread_plan_actions (TestThreadPlanCommands.TestThreadPlanCommands)
======================================================================
ERROR: test_thread_plan_actions (TestThreadPlanCommands.TestThreadPlanCommands)
----------------------------------------------------------------------
TypeError: WrapStepOver.__init__() missing 1 required positional argument: 'dict'

And I see that the previous special case Python object maker thingy (can you tell I know nothing about this :) ) did pass on, or make a dict of some sort.

The others seemed to be trying to create a plan, which failed (same reason I expect), then tried to use it which of course failed.

medismailben · 2023-11-03T17:00:36Z

@DavidSpickett Checking! Thanks for the heads-up.

…70392) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…eadPlan (#70392)" Temporarily revert to unblock the CI bots, this is breaking the -DLLVM_ENABLE_MODULES=On modules style build. I've notified Ismail. This reverts commit 888501b.

…lvm#70392) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…(Reland #70392) (#93149) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. This just re-lands #70392 after fixing test failures. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…eadPlan (Reland #70392)" (#93153) Reverts #93149 since it breaks https://lab.llvm.org/buildbot/#/builders/68/builds/74799

…lvm#70392) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. This just re-lands llvm#70392 after fixing test failures. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…70392) (#96868) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. This just re-lands #70392 after fixing test failures. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

…lvm#70392) (llvm#96868) This patch makes ScriptedThreadPlan conforming to the ScriptedInterface & ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface & ScriptedThreadPlanPythonInterface classes. This allows us to get rid of every ScriptedThreadPlan-specific SWIG method and re-use the same affordances as other scripting offordances, like Scripted{Process,Thread,Platform} & OperatingSystem. To do so, this adds new transformer methods for `ThreadPlan`, `Stream` & `Event`, to allow the bijection between C++ objects and their python counterparts. This just re-lands llvm#70392 after fixing test failures. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

medismailben requested a review from JDevlieghere as a code owner October 26, 2023 23:31

llvmbot added the lldb label Oct 26, 2023

medismailben force-pushed the main branch from ef90c8a to 76f6551 Compare October 26, 2023 23:32

medismailben requested a review from bulbazord October 26, 2023 23:32

medismailben force-pushed the main branch from 76f6551 to 7366abe Compare October 26, 2023 23:36

medismailben changed the title ~~[lldb/Interpreter] Make ScriptedInterface Object creation more generic~~ [lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan Oct 26, 2023

medismailben force-pushed the main branch from 7366abe to 836bafb Compare October 27, 2023 00:02

bulbazord reviewed Oct 27, 2023

View reviewed changes

medismailben force-pushed the main branch 2 times, most recently from 086c5f8 to 56f95c1 Compare October 27, 2023 22:20

bulbazord approved these changes Oct 27, 2023

View reviewed changes

JDevlieghere approved these changes Oct 30, 2023

View reviewed changes

Comment thread lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.cpp Outdated

Comment thread lldb/source/Target/ThreadPlanPython.cpp Outdated

medismailben force-pushed the main branch from 56f95c1 to 4840384 Compare October 30, 2023 23:35

medismailben merged commit 4b3cd37 into llvm:main Oct 30, 2023

medismailben mentioned this pull request May 23, 2024

[lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan (Reland #70392) #93149

Merged

medismailben added a commit that referenced this pull request May 23, 2024

Revert "[lldb] Make use of Scripted{Python,}Interface for ScriptedThr…

ae3f680

…eadPlan (Reland #70392)" (#93153) Reverts #93149 since it breaks https://lab.llvm.org/buildbot/#/builders/68/builds/74799

medismailben mentioned this pull request Jun 27, 2024

[lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan (#70392) #96868

Merged

Navigation Menu

Uh oh!

[lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan - #70392

[lldb] Make use of Scripted{Python,}Interface for ScriptedThreadPlan#70392
medismailben merged 1 commit into
llvm:mainfrom
medismailben:main

medismailben commented Oct 26, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bulbazord left a comment

Uh oh!

JDevlieghere left a comment

Uh oh!

Uh oh!

Uh oh!

medismailben commented Oct 31, 2023

Uh oh!

DavidSpickett commented Nov 3, 2023

Uh oh!

medismailben commented Nov 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

medismailben commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bulbazord left a comment

Choose a reason for hiding this comment

Uh oh!

JDevlieghere left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

medismailben commented Oct 31, 2023

Uh oh!

DavidSpickett commented Nov 3, 2023

Uh oh!

medismailben commented Nov 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

medismailben commented Oct 26, 2023 •

edited

Loading