Skip to content

[libc++][test] Move format.functions ASCII tests to libcxx/test/libcxx - #78661

Merged
StephanTLavavej merged 2 commits into
llvm:mainfrom
StephanTLavavej:ascii-art
Jan 20, 2024
Merged

[libc++][test] Move format.functions ASCII tests to libcxx/test/libcxx#78661
StephanTLavavej merged 2 commits into
llvm:mainfrom
StephanTLavavej:ascii-art

Conversation

@StephanTLavavej

Copy link
Copy Markdown
Member

As @cpplearner explained in microsoft/STL#4328:

libc++'s "ascii" mode (controlled by the _LIBCPP_HAS_NO_UNICODE macro) means "every code unit outside ASCII is treated as a valid printable character". AFAIK we [MSVC's STL] don't support such a mode.

Because these files are testing a non-Standard mode, they should be moved from libcxx/test/std to libcxx/test/libcxx.

They're testing a non-Standard mode.
@StephanTLavavej
StephanTLavavej requested a review from a team as a code owner January 19, 2024 02:22
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 19, 2024
@llvmbot

llvmbot commented Jan 19, 2024

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-libcxx

Author: Stephan T. Lavavej (StephanTLavavej)

Changes

As @cpplearner explained in microsoft/STL#4328:

> libc++'s "ascii" mode (controlled by the _LIBCPP_HAS_NO_UNICODE macro) means "every code unit outside ASCII is treated as a valid printable character". AFAIK we [MSVC's STL] don't support such a mode.

Because these files are testing a non-Standard mode, they should be moved from libcxx/test/std to libcxx/test/libcxx.


Full diff: https://github.com/llvm/llvm-project/pull/78661.diff

2 Files Affected:

  • (renamed) libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp ()
  • (renamed) libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp ()
diff --git a/libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
diff --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp

@github-actions

github-actions Bot commented Jan 19, 2024

Copy link
Copy Markdown

✅ With the latest revision this PR passed the C/C++ code formatter.

@mordante mordante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephanTLavavej
StephanTLavavej merged commit 123ab34 into llvm:main Jan 20, 2024
@StephanTLavavej
StephanTLavavej deleted the ascii-art branch January 20, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants