Uh oh!
There was an error while loading. Please reload this page.
smite-scenarios: convert execute fn into Executor struct - #117
Conversation
d65f690 to
e4629faCompare
ekzyis
left a comment
There was a problem hiding this comment.
LGTM
nit: commit message mentions "owns the resources", but I think "borrow" is more accurate
| fn run(&mut self, input: &[u8]) -> ScenarioResult { | ||
| let start = std::time::Instant::now(); | ||
| let mut bitcoin_cli = self.target.bitcoin_cli().clone(); |
There was a problem hiding this comment.
nit: could move this to where it's needed?
ff628b8 to
dc5480cCompareThere was a problem hiding this comment.
ACK dc5480c
CI failure looks unrelated, should work on force-push:
build (eclair)
ERROR: Error response from daemon: Get "https://registry-1.docker.io/v2/": context deadline exceeded
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Move execution state into an Executor struct that encapsulates the state and handles required during program execution. This prepares for future changes that will add channel state to the executor, maintaining a ChannelId -> ChannelState mapping so IR operations can read and mutate channel-specific state throughout execution. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
dcc237d to
70f12c5CompareUh oh!
There was an error while loading. Please reload this page.
ref: #111 (comment)
Move execution state into an
Executorstruct that owns the resources used during program execution. This prepares for future changes that will add channel state to the executor, maintaining aChannelId -> ChannelStatemapping so IR operations can read and mutate channel-specific state throughout execution.Now, during the funding flow, we can add a
ChannelStatefield that is populated duringBuildFundingCreatedand later used to verify the signature received inRecvFundingSigned(See: #103 (comment)).