Uh oh!
There was an error while loading. Please reload this page.
smite-scenarios: skip RecvChannelReady on premature funding tx - #171
Merged
Conversation
If the funding transaction was mined before sending it to the target via funding_created, the target may never detect the funding transaction on chain and will therefore fail to send us channel_ready. Make RecvChannelReady a no-op in this case.
NishantBansal2003
approved these changes
Jul 29, 2026
NishantBansal2003
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
This approach gave me an idea that could be implemented in the future: maintain a HashMap<txid, confirmations>. This would replace both the unmined_txids and mined_txidsHashSet with a single map, while avoiding repeated get_transaction_confirmations RPC calls during sequences like MineBlock -> RecvChannelReady until state.config.minimum_depth is reached
Uh oh!
There was an error while loading. Please reload this page.
morehouse
commented
Jul 29, 2026
CollaboratorAuthor
Cool idea. Anything to reduce unnecessary RPC calls would be good for improving speed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the funding transaction was mined before sending it to the target via
funding_created, the target may never detect the funding transaction on chain and will therefore fail to send uschannel_ready. MakeRecvChannelReadya no-op in this case.This was found to occur while fuzzing both LDK and LND.