Uh oh!
There was an error while loading. Please reload this page.
feat(novelbuddy): optimize performance and improve watermark removal - #2198
Conversation
…mp version to 2.1.2
K1ngfish3r
left a comment
There was a problem hiding this comment.
I dont like using regex for urls, any reason why this is being done?
Other than that, real nice
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
When I used the old method to download stories with over 1,000 chapters, it took quite a while—more than 5 seconds to finish. For some stories with over 3,000 chapters, it took over 10 seconds. But when I tried using regex, the download speed was super fast, taking less than 2 seconds to complete. |
This comment was marked as low quality.
This comment was marked as low quality.
run prettier on your file and I merge, for the regex master has spoken thusly |
No wait 7ui77
the one u used doesnt cover everything, added 4 or 5 missing found by testing on fwn |
- Replace regex-based URL path manipulation with startsWith and slice. - Update fwnRegex with a more comprehensive pattern. - Run npm run format.
7ui77
commented
May 19, 2026
Thanks, I'm going to adjust the regex. |
- Integrate the newest provided fwnRegex pattern. - Ensure non-capturing groups and special characters are correctly handled. - Maintain addressing of reviewer feedback regarding URL manipulation. - Run npm run format.
K1ngfish3r
left a comment
There was a problem hiding this comment.
regex has more items now
Uh oh!
There was an error while loading. Please reload this page.
…nreader#2198) * fix(novelbuddy): fix watermark regex and bump version to 2.1.2 * fix(novelbuddy): fix watermark regex, remove chapter api fetch and bump version to 2.1.2 * Update novelbuddy.ts * feat(novelbuddy): optimize performance and improve watermark removal * feat(novelbuddy): optimize performance and improve watermark removal (v2.1.2) * chore: restore original index.ts to ensure clean PR * refactor: address reviewer feedback and update watermark regex - Replace regex-based URL path manipulation with startsWith and slice. - Update fwnRegex with a more comprehensive pattern. - Run npm run format. * refactor: update watermark regex to latest comprehensive pattern - Integrate the newest provided fwnRegex pattern. - Ensure non-capturing groups and special characters are correctly handled. - Maintain addressing of reviewer feedback regarding URL manipulation. - Run npm run format.
Optimized NovelBuddy plugin to improve performance and watermark removal.
Changes:
Version: 2.1.2