Uh oh!
There was an error while loading. Please reload this page.
fix test_port_host_dispatcher with new werkzeug version - #37
Merged
Conversation
bentsku
approved these changes
Apr 2, 2026
bentsku
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Quick and simple fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit pallets/werkzeug@d3d3df5, released with werkzeug v3.1.7, introduced syntax checking on the target host port, and raises a different exception now.
This PR fixes a test assert that's compatible with this newer version.
Changes
test_port_host_dispatcherto also check for the new exception, no impact on rolo otherwise