Stabilize provider and workspace connection status - #27
Conversation
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Warning Review limit reached
Next review available in:46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesSQLite busy-timeout configuration
Provider status handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CodexProvider
participant ProviderRegistry
participant ProviderStatusBanner
CodexProvider->>ProviderRegistry: publish warning timeout with unknown authentication
ProviderRegistry->>ProviderRegistry: preserve previous ready snapshot
ProviderRegistry->>ProviderStatusBanner: expose merged provider status
ProviderStatusBanner->>ProviderStatusBanner: render only actionable errors
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/server/src/persistence/NodeSqliteClient.test.ts`:
- Around line 32-40: Rename the test to describe asserting the default PRAGMA
busy_timeout value rather than cross-process write waiting. Extend the
NodeSqliteClient test coverage with focused cases for explicit, fractional,
negative, and non-finite busyTimeoutMs configurations, asserting each resulting
PRAGMA value and preserving the default-path assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ff6b483c-745f-4aeb-8e78-3a8eae3d3077
📒 Files selected for processing (10)
apps/server/src/persistence/NodeSqliteClient.test.tsapps/server/src/persistence/NodeSqliteClient.tsapps/server/src/provider/Layers/ClaudeProvider.tsapps/server/src/provider/Layers/CodexProvider.tsapps/server/src/provider/Layers/ProviderRegistry.test.tsapps/server/src/provider/Layers/ProviderRegistry.tsapps/web/src/components/chat/ProviderStatusBanner.test.tsxapps/web/src/components/chat/ProviderStatusBanner.tsxapps/web/src/components/settings/providerStatus.test.tsapps/web/src/components/settings/providerStatus.ts
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:e655ad6ff3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What changed
database is lockedand triggering workspace reconnect loops.Root cause
Periodic provider probes could overwrite a healthy provider snapshot with an inconclusive warning/error, and the global banner rendered those non-actionable states as connection failures. Separately, the DevPC workspace gateway launches a short-lived pairing command against the same SQLite database as the running server; with SQLite's default zero busy timeout, transient writer overlap returned HTTP 500 and caused repeated relay reconnect attempts.
Impact
Healthy providers no longer produce false connection/authentication alerts after a transient probe failure. Managed workspace pairing tolerates short-lived SQLite writer contention, addressing the observed constant reconnecting loop.
Validation
vp fmt --checkpassed for all 10 changed files.git diff --checkpassed.BEGIN IMMEDIATESQLite writer lock passed after 1.869 seconds.Local limitations
The package typecheck was resource-bound on the shared VM and was stopped after 12 minutes; the required Node 24 CI typecheck is the gate. Product-native preview automation was unavailable, and the shared Chrome CDP fallback timed out under concurrent compiler load, so integrated browser screenshots are deferred to a clean environment/production verification. Focused UI regression tests and the managed production build passed locally.
No schema migration or credential changes are included.
Summary by CodeRabbit
Bug Fixes
Provider Status
UI Improvements