Authorize managed WebSocket reconnects - #3
Conversation
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Warning Review limit reached
Next review available in:55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds managed DevPC WebSocket URL authorization. Primary connection resolution now prepares socket URLs through a platform capability, while the web implementation fetches fresh gateway tickets and rewrites managed URLs. CI and release checks verify the authorization path is present in built assets. ChangesManaged WebSocket authorization
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ConnectionResolver
participant PrimaryEnvironmentAuth
participant ManagedDevPc
participant DevPcGateway
ConnectionResolver->>PrimaryEnvironmentAuth: prepareWebSocketUrl(socketUrl)
PrimaryEnvironmentAuth->>ManagedDevPc: prepareManagedWebSocketUrl(socketUrl)
ManagedDevPc->>DevPcGateway: POST /_devpc/ws-ticket
DevPcGateway-->>ManagedDevPc: ticket
ManagedDevPc-->>PrimaryEnvironmentAuth: URL with gatewayTicket
PrimaryEnvironmentAuth-->>ConnectionResolver: prepared socketUrl
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/client-runtime/src/connection/resolver.test.ts (1)
92-100: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake WebSocket URL preparation injectable in resolver tests.
The hard-coded identity implementation cannot verify either primary branch invokes preparation or propagates its failure. Add an optional
prepareWebSocketUrldependency and cover bearer and no-bearer transformations.Also applies to: 173-175
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/client-runtime/src/connection/resolver.test.ts` around lines 92 - 100, Add an optional prepareWebSocketUrl dependency to makeDependencies and wire it into the test resolver setup, replacing the hard-coded identity implementation. Extend the bearer and no-bearer resolver tests to assert the preparation function is invoked and that its transformed URL is used, including propagation of preparation failures.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/client-runtime/src/connection/resolver.test.ts`:
- Around line 92-100: Add an optional prepareWebSocketUrl dependency to
makeDependencies and wire it into the test resolver setup, replacing the
hard-coded identity implementation. Extend the bearer and no-bearer resolver
tests to assert the preparation function is invoked and that its transformed URL
is used, including propagation of preparation failures.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2df26ded-66ad-443a-a611-49bd80b5704d
📒 Files selected for processing (9)
.github/workflows/devpc-managed-ci.yml.github/workflows/devpc-managed-release.ymlapps/mobile/src/connection/platform.tsapps/web/src/connection/platform.tsapps/web/src/managedDevPc.test.tsapps/web/src/managedDevPc.tspackages/client-runtime/src/connection/resolver.test.tspackages/client-runtime/src/connection/resolver.tspackages/client-runtime/src/platform/capabilities.ts
Summary
Verification
pnpm exec vp test apps/web/src/managedDevPc.test.ts packages/client-runtime/src/connection/resolver.test.ts --run(10 passed)pnpm typecheck(passed)pnpm lint(passed with existing warnings)pnpm fmt:check(passed)vp run --filter t3 build(passed)pnpm test(Windows-only oxlint test launcher failed because it resolves an extensionless.bin/oxlint; managed CI runs on Ubuntu)Deployment impact
A new managed T3 release artifact is required. No database migration or server-runtime change.
Summary by CodeRabbit
New Features
Bug Fixes
Tests