Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add configurable Aldo Review swarm - #43

Merged
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration
Aug 1, 2026
Merged

Add configurable Aldo Review swarm#43
logancsack merged 2 commits into
mainfrom
feature/aldo-review-configuration

Conversation

@logancsack

@logancsacklogancsack commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • brand the existing Grok review capability as Aldo Review across settings, MCP, HTTP, and reports
  • let users select any connected provider and advertised model, while preserving the hardened Grok 4.5 medium-to-high reasoning path
  • make the review swarm faster and safer with tool-free primary passes, bounded read-only delegation, generic-provider isolation, structured-output normalization, and actionable partial-failure diagnostics
  • keep the legacy grok_review tool and /api/review/grok route as compatibility aliases

Verification

  • pnpm typecheck (passed; existing Effect suggestions only)
  • pnpm lint (passed; existing warnings only)
  • pnpm test (all packages completed; server had 1 timing-sensitive GrokAdapter test failure out of 1,729 tests)
  • pnpm vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (20 passed on isolated rerun)
  • focused Aldo Review suites (39 tests passed after the final changes)
  • managed production build with VITE_DEVPC_MANAGED=1, T3CODE_MANAGED_DEVPC=1, and telemetry disabled (passed)
  • live /api/review/aldo run using connected Grok 4.5 (HTTP 200, medium reasoning, seven agent runs, unified Aldo Review markdown)
  • responsive browser QA at 1440x1000 and 390x844 (passed)

Release impact

This changes the managed T3 artifact. After merge it needs a new devpc managed release tag and a separate pin-only PR in the Aldo platform repository.

Summary by CodeRabbit

  • New Features

    • Introduced Aldo Review as the primary code review experience, with updated naming and reporting.
    • Added provider and model selection, allowing reviews to use eligible configured AI providers.
    • Added an Aldo Review API route and tool while retaining the existing Grok Review option for compatibility.
    • Added provider-specific review execution and improved support for structured review results.
  • Bug Fixes

    • Improved review error reporting, partial-result handling, and unavailable-provider diagnostics.
    • Increased review execution limits and improved high-effort review fallback behavior.

@cursor

cursorBot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Aug 1, 2026
@coderabbitai

coderabbitaiBot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@logancsack, you've reached your PR review limit, so we couldn't start this review.

Next review available in:30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7c5a4d7-476c-448e-b849-dc842bfc3d6b

📥 Commits

Reviewing files that changed from the base of the PR and between b4489e2 and d36a2be.

📒 Files selected for processing (28)
  • apps/server/src/git/GitManager.test.ts
  • apps/server/src/mcp/toolkits/review/handlers.ts
  • apps/server/src/mcp/toolkits/review/tools.test.ts
  • apps/server/src/mcp/toolkits/review/tools.ts
  • apps/server/src/review/GrokReviewAgent.test.ts
  • apps/server/src/review/GrokReviewAgent.ts
  • apps/server/src/review/GrokReviewHttp.ts
  • apps/server/src/review/GrokReviewModel.ts
  • apps/server/src/review/GrokReviewPrompts.ts
  • apps/server/src/review/GrokReviewService.test.ts
  • apps/server/src/review/GrokReviewService.ts
  • apps/server/src/review/GrokReviewSwarm.test.ts
  • apps/server/src/review/GrokReviewSwarm.ts
  • apps/server/src/review/GrokReviewSwarmProbe.test.ts
  • apps/server/src/review/ProviderCodeReview.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
  • apps/server/src/textGeneration/ClaudeTextGeneration.ts
  • apps/server/src/textGeneration/CodexTextGeneration.ts
  • apps/server/src/textGeneration/CursorTextGeneration.ts
  • apps/server/src/textGeneration/GrokTextGeneration.ts
  • apps/server/src/textGeneration/OpenCodeTextGeneration.ts
  • apps/server/src/textGeneration/TextGeneration.test.ts
  • apps/server/src/textGeneration/TextGeneration.ts
  • apps/server/src/textGeneration/TextGenerationPrompts.test.ts
  • apps/server/src/textGeneration/TextGenerationUtils.ts
  • apps/web/src/components/settings/GrokReviewSettings.test.ts
  • apps/web/src/components/settings/GrokReviewSettings.tsx
  • packages/contracts/src/review.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/aldo-review-configuration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ccc4176ec7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/textGeneration/CursorTextGeneration.ts
Comment threadapps/web/src/components/settings/GrokReviewSettings.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d36a2beb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const agent: GrokReviewAgent = {
resolvedModel: input.modelSelection.model,
grokBuildVersion: null,
supportsHighEffort: input.driver === CODEX_DRIVER || input.driver === CLAUDE_DRIVER,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive high-effort support from the selected model

When a Claude model without an effort control is selected—such as claude-haiku-4-5, whose capabilities expose only thinking—this driver-level check still enables escalation. ClaudeTextGeneration then drops the injected effort: "high" because resolveClaudeEffort cannot resolve it, but the swarm records the second run as a successful high-effort pass and sets escalatedToHigh. Determine support from the selected model's capability descriptors so reports do not claim an escalation that never occurred.

Useful? React with 👍 / 👎.

@logancsack
logancsack merged commit 606275e into mainAug 1, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@logancsack