Clarify managed workspace wake progress - #48
Conversation
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Warning Review limit reached
Next review available in:49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughManaged DevPC bootstrap and resume flows now show machine, connection, and workspace wake phases. The UI includes elapsed timing, delayed-state guidance, accessible progress semantics, retry handling, and animated progress styling. ChangesManaged wake progress
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant BootstrapPolling
participant WakePresentation
participant WorkspaceStatusScreen
BootstrapPolling->>WakePresentation: pass lifecycle snapshot and elapsed time
WakePresentation-->>WorkspaceStatusScreen: return phase-specific status data
WorkspaceStatusScreen->>WorkspaceStatusScreen: update progress, timing, and delayed guidance
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d17ab82000
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/managedDevPc.ts`:
- Around line 358-361: Update the wake-state announcement logic around
announcePhase to track the delayed-state transition in addition to phase
changes, setting aria-live to "polite" when either changes. Ensure the
nonfailure waiting state sets surface.ariaBusy to "false" so delayed guidance is
announced without remaining deferred; preserve assertive announcements for
failures and update the stored announcement state after each transition.
- Around line 128-132: Update managedWakePhase to return "workspace" for a
confirmed running workspace before evaluating the connected or reconnecting
connection phase, while preserving the existing machine fallback. Add an
assertion in managedDevPc.test.ts covering a bootstrap snapshot representing a
running workspace.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 85f5cdc9-b188-4766-a5ce-cf66e0ab4780
📒 Files selected for processing (3)
apps/web/src/index.cssapps/web/src/managedDevPc.test.tsapps/web/src/managedDevPc.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:7e4a42b419
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7e4a42b to
68c8997CompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:68c8997ccb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const card = document.createElement("section"); | ||
| card.className = | ||
| "w-full max-w-sm rounded-xl border border-border bg-card p-6 text-center shadow-sm"; | ||
| "managed-wake-surface flex h-dvh min-h-0 justify-center overflow-x-hidden overflow-y-auto bg-background px-6 py-12 text-foreground"; |
There was a problem hiding this comment.
On a short viewport where this new surface needs overflow-y-auto, prepareManagedDevPc calls updateBootstrapMessage after each 1.5-second poll, and that function replaces the entire surface via root.replaceChildren(). Each replacement creates a new scroll container at scrollTop = 0, so a user who scrolls to the timing or delayed guidance is repeatedly jumped back before they can read it. The current version's added scrolling is fresh evidence beyond the earlier clipping report, but it needs a stable container or explicit scroll-position preservation across polls.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Problem
A cold managed-workspace wake can take about a minute, but the pre-app shell repeated one static message. Customers could not distinguish healthy wake progress from a hung page.
Solution
Verification
pnpm exec vp test run apps/web/src/managedDevPc.test.ts— 27 passedpnpm --filter @t3tools/web typecheck— passedpnpm exec vp lint apps/web/src/managedDevPc.ts apps/web/src/managedDevPc.test.ts— passedpnpm exec vp fmt --check apps/web/src/managedDevPc.ts apps/web/src/managedDevPc.test.ts apps/web/src/index.css— passedoutput/playwright/wake-machine-desktop.png,wake-machine-mobile.png,wake-connection-desktop.png,wake-delayed-mobile.png, andwake-connection-mobile-dark.pngImpact
No schema, infrastructure, or security-boundary changes. This changes only the managed client's pre-React wake presentation. Aldo staging will consume it through a separately pinned immutable release after merge.
Summary by CodeRabbit
New Features
Bug Fixes