Keep managed recovery interactive - #50
Conversation
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe client runtime now waits for reconnectable primary sessions before dispatching selected RPCs. ChatView identifies managed primary recovery and suppresses unavailable-environment action blocking during connecting or reconnecting phases. ChangesManaged primary recovery
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ChatView
participant requestWhenConnected
participant Supervisor
participant PrimarySession
ChatView->>requestWhenConnected: dispatch command
requestWhenConnected->>Supervisor: wait for reconnectable primary session
Supervisor-->>requestWhenConnected: return active session
requestWhenConnected->>PrimarySession: send unary RPC
PrimarySession-->>ChatView: complete command request
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:17e89dc103
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function dispatch(command: ClientOrchestrationCommand) { | ||
| return request(ORCHESTRATION_WS_METHODS.dispatchCommand, command); | ||
| return requestWhenConnected(ORCHESTRATION_WS_METHODS.dispatchCommand, command); |
There was a problem hiding this comment.
When the primary environment is not a managed DevPC and is in connecting/backoff, this shared dispatch still calls requestWhenConnected, and dispatchSession waits for the next session for every PrimaryConnectionTarget. Sidebar/project mutations such as archive/delete/update call this helper without ChatView's managed-only guard, so disconnected local/unmanaged users now get actions that remain pending until a retry succeeds instead of the existing unavailable error. Please keep the deferred path behind the managed-primary recovery opt-in or use the immediate request for normal orchestration dispatches.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Problem
Managed T3 surfaces expose a blocking reconnect state while the host quietly resumes or restarts the workspace. User actions also fail immediately during that recoverable connection window.
Solution
Verification
pnpm exec vitest run apps/web/src/components/ChatView.logic.test.ts packages/client-runtime/src/rpc/client.test.ts packages/client-runtime/src/operations/commands.test.ts— 47 tests passedpnpm --filter @t3tools/client-runtime typecheck— passedpnpm --filter @t3tools/web typecheck— passedVITE_DEVPC_MANAGED=1 T3CODE_MANAGED_DEVPC=1 T3CODE_TELEMETRY_ENABLED=false pnpm exec vp run --filter t3 build— passedgit diff --check— passedRelease impact
Requires a new checksummed DevPC T3 artifact and a corresponding remote-dev manifest pin. No schema, infrastructure, or production deployment changes.
Summary by CodeRabbit