Skip to content

Release Notes and Upgrade guide reorg - #136

Merged
crandmck merged 3 commits into
gh-pagesfrom
RNs-reorg
Oct 26, 2016
Merged

Release Notes and Upgrade guide reorg#136
crandmck merged 3 commits into
gh-pagesfrom
RNs-reorg

Conversation

@crandmck

@crandmckcrandmck commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

I tried to organize the items in the Rel. Notes and Migration Guide to group related things. I also edited it extensively, and add cross-links. I'll probably make at least one more pass to link into the rest of the docs, once I populate the lb3 docs.

@Amir-61@bajtos

@bajtosbajtos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment threadpages/en/lb3/3.0-Release-Notes.md Outdated
one singleton instance of model registry. This was very fragile and might not
## Changes to loopback-datasource-juggler

### loopback-datasource-juggler is now a regular dependency

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made in loopback, not in loopback-datasource-juggler. I am not sure whether it makes sense to list it under "Changes to loopback-datasource-juggler"?

Also I would add "of loopback" at the end of the title, to prevent confusion.

loopback-datasource-juggler is now a regular dependency of loopback

@Amir-61Amir-61Oct 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I discussed this one with @crandmck. Then let's move it under Other changes.

Comment threadpages/en/lb3/3.0-Release-Notes.md Outdated
```

For more information, see [loopback-datasource-juggler#918](https://github.com/strongloop/loopback-datasource-juggler/pull/918).
## Changes to to LoopBack models

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: to to.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

@Amir-61Amir-61 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crandmck
crandmck merged commit f4d2655 into gh-pagesOct 26, 2016
@Amir-61
Amir-61 deleted the RNs-reorg branch October 26, 2016 17:34
@crandmck

Copy link
Copy Markdown
ContributorAuthor

Thanks! We can also continue to refine this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crandmck@bajtos@Amir-61