Uh oh!
There was an error while loading. Please reload this page.
Describe Authorization scopes - #338
Conversation
f86fa19 to
9b37503Comparebajtos
commented
Mar 29, 2017
(This pull request must not be landed before the change in LoopBack is finished.) |
crandmck
commented
Apr 4, 2017
Actually, the doc PR should not be landed until the code is landed AND published to npm. |
9b37503 to
e5dbb0fComparebajtos
commented
Apr 7, 2017
I have reworked the pull request to match what has been landed by strongloop/loopback#3313. |
e5dbb0f to
430de8aCompareThere was a problem hiding this comment.
I went ahead and made wording and grammar edits directly in the branch, since that seemed most efficient.
IIUC, we should also update https://loopback.io/doc/en/lb3/Model-definition-JSON-file.html#methods since this feature will now be implemented. Is that right?
If so, please add to this PR--or if you prefer I can take a stab at it next week.
Again, if I'm understanding, this reference info should largely duplicate what's in https://loopback.io/doc/en/lb3/Remote-methods.html#options. If so, then instead of
actually duplicating these tables, we can move them into the _includes/content and
single-source them so we only have to maintain them there.
| The scopes are defined together with other remoting metadata via the new | ||
| setting `accessScopes`. The user can invoke the remote method as long as their access token | ||
| is granted at least one of the scopes listed in `accessScopes` array. | ||
| The new model property `accessScopes` defines scopes as part of remoting metadata. |
There was a problem hiding this comment.
@crandmckaccessScopes is not a model property, it is a new property in remote method metadata. My proposal:
- The new model property `accessScopes` defines scopes as part of remoting metadata.+ The new setting `accessScopes` defines scopes as part of remoting metadata.There was a problem hiding this comment.
IIUC, it's a value set in the model JSON file, which is what I meant by a "model property". Apparently that is confusing, but "setting" doesn't really convey any specific meaning.
Perhaps it would be clearer to say
The
methods.accessScopesproperty in the model JSON file defines...
bajtos
commented
Apr 11, 2017
@crandmck thank you for the edits. Good catch,
I am confused. The current doc pages says that remote methods cannot be configured via JSON files yet, but that hasn't been true for months. So yes, we should fix that section and I think that fix is independent of the changes I am making here. I am proposing to leave that out of scope of this pull request.
Ditto, I am proposing to leave |
bajtos
commented
Apr 11, 2017
Updated, PTAL. |
No one told me, created an issue, or opened a doc PR, so apparently it was not documented (unless I'm missing something). It's closely related to this PR, but we can do it separately if you prefer. With one small edit noted above I think this is ready to land, WHEN the change is published to npm. We shouldn't land this until that time, though. |
crandmck
commented
Apr 14, 2017
b3b812c to
ac92730Comparebajtos
commented
Apr 18, 2017
Rebased, I moved the newly-added remote method option "accessScopes" to the new place you created.
Sounds good. I'd like to land strongloop/loopback#3350 before making a new loopback 3.x release. |
bajtos
commented
Apr 27, 2017
All required changes were landed and released in |
ac92730 to
65eea1fCompare65eea1f to
96c0fd8Compare
Documentation for the new feature to be added by strongloop/loopback#3313.
Connect to strongloop/loopback#382