Skip to content

typo ? - #30

Closed
brownman wants to merge 1 commit into
loopbackio:masterfrom
brownman:patch-1
Closed

typo ?#30
brownman wants to merge 1 commit into
loopbackio:masterfrom
brownman:patch-1

Conversation

@brownman

Copy link
Copy Markdown

rm ','

rm ','
@slnode

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

Copy link
Copy Markdown

Can one of the admins verify this patch?

@davidcheung

Copy link
Copy Markdown
Contributor

thanks @brownman, can you sign the CLA as well?
and can u change the commit title to something like

fix typo in readme

@slnode test please

@davidcheungdavidcheung self-assigned this Nov 28, 2016
@superkhau

superkhau commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

Closing as rejected as the trailing comma should be there, see https://github.com/strongloop/eslint-config-loopback/blob/master/eslint.json#L10

@slnode

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@superkhau

Copy link
Copy Markdown
Contributor

Looked at this more carefully after being ping by @davidcheung, this is legit. Reopening.

@superkhau

Copy link
Copy Markdown
Contributor

@brownman Can you sign he CLA please? 🙇‍♂️

@cgolecgole removed the #review label Jan 7, 2017
@davidcheung

Copy link
Copy Markdown
Contributor

@brownman thanks for the contribution, closing this in favor of #36

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@brownman@slnode@davidcheung@superkhau@cgole@crandmck@brownman556