Skip to content

Bump third_party/opentelemetry-cpp from 9e93606 to 767f797 - #44

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/submodules/third_party/opentelemetry-cpp-e0c6c33
Closed

Bump third_party/opentelemetry-cpp from 9e93606 to 767f797#44
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/submodules/third_party/opentelemetry-cpp-e0c6c33

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 14, 2026

Copy link
Copy Markdown
Contributor

Bumps third_party/opentelemetry-cpp from 9e93606 to 767f797.

Commits
  • 767f797 docs: Expand SIG meeting welcoming language (#4064)
  • 5f3a216 [CI] Use fixed versions in iwyu CI & dev container (#4051)
  • 93fae28 [API] Fix Logger.Enabled() (#4011)
  • 0d35a81 [Docs] Fix Read the Docs configuration (#4058)
  • b5f7c35 [EXPORTER] Implement non-utf8 string to bytes in OTLP (#3991)
  • fe67988 [SDK] Fix overflow attribute name to match the spec (otel.metric.overflow) (#...
  • 222d3e0 [EXPORTER] Fix PrometheusExporter to propagate new options to collector (#4055)
  • ec85d57 Bump benchmark-action/github-action-benchmark from 1.22.0 to 1.22.1 (#4059)
  • 9180527 [CODE HEALTH] fix nondeterministic pointer iteration order warnings (#4035)
  • 029f74e Bump step-security/harden-runner from 2.18.0 to 2.19.1 (#4056)
  • Additional commits viewable in compare view

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label May 14, 2026
@ltowarek

Copy link
Copy Markdown
Owner

@dependabot recreate

Bumps [third_party/opentelemetry-cpp](https://github.com/ltowarek/opentelemetry-cpp) from `9e93606` to `767f797`.
- [Commits](ltowarek/opentelemetry-cpp@9e93606...767f797)

---
updated-dependencies:
- dependency-name: third_party/opentelemetry-cpp
  dependency-version: e0c6c3389bbc0eb1fde87437ec88e222e30958a9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump third_party/opentelemetry-cpp from 2d80af1 to e0c6c33 Bump third_party/opentelemetry-cpp from 9e93606 to 767f797 Jun 13, 2026
@dependabot
dependabot Bot force-pushed the dependabot/submodules/third_party/opentelemetry-cpp-e0c6c33 branch from 8e6a80a to 24502bf Compare June 13, 2026 22:34
@ltowarek
ltowarek enabled auto-merge (squash) June 13, 2026 22:35
@ltowarek

Copy link
Copy Markdown
Owner

@claude fix it

@claude

claude Bot commented Jun 14, 2026

Copy link
Copy Markdown

Claude finished @ltowarek's task in 6m 4s —— View job


Summary

  • Gather context on the PR and current branch state
  • Understand the request ("fix it")
  • Investigate CI failure on this PR
  • Identify root cause
  • Implement fix — blocked, see below

What's failing

CI run 27481140567 fails on build (tracing/batch example, examples/tracing/batch) (the other example builds were cancelled as a result, likely fail-fast). The configure step errors with:

CMake Error at .../FindPackageHandleStandardArgs.cmake:227 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR)
Call Stack (most recent call first):
  .../FindOpenSSL.cmake:658 (find_package_handle_standard_args)
  build/_deps/curl-src/CMakeLists.txt:802 (find_package)

Root cause analysis

This repo's CMakeLists.txt:93 explicitly sets WITH_HTTP_CLIENT_CURL OFF before add_subdirectory(third_party/opentelemetry-cpp), precisely so curl is never fetched/built for the Xtensa cross-compile (it can't link against OpenSSL on that toolchain). PR #30 (b6a0559) made this work by switching to the correct WITH_HTTP_CLIENT_CURL flag and bumping third_party/opentelemetry-cpp to a fork commit (9e93606) carrying the custom opentelemetry_http_client interface (open-telemetry/opentelemetry-cpp#4071).

This PR bumps third_party/opentelemetry-cpp from 9e93606767f797. The commit list for that range (docs, CI fixes, API fixes, exporter fixes, GH Action bumps) reads like generic upstream open-telemetry/opentelemetry-cpp history rather than fork-specific commits — which suggests the custom WITH_HTTP_CLIENT_CURL/opentelemetry_http_client patch from PR #4071 that PR #30 relied on may no longer be effective at 767f797 in the ltowarek/opentelemetry-cpp fork, causing exporters/otlp's CMake to fall back to fetching/building curl (which then fails to find OpenSSL during the cross-compile).

Why I can't implement a fix right now

The submodule third_party/opentelemetry-cpp isn't checked out in this sandbox, and git fetch/git submodule update/WebFetch to inspect exporters/otlp/CMakeLists.txt at 767f797 vs 9e93606 all require approvals I don't have here. Without seeing what changed in the fork's CMake around WITH_HTTP_CLIENT_CURL / opentelemetry_http_client, I can't safely determine whether the fix belongs in:

  • this repo's CMakeLists.txt (e.g. a new/renamed flag is needed alongside WITH_HTTP_CLIENT_CURL=OFF), or
  • the ltowarek/opentelemetry-cpp fork itself (the custom patch needs to be re-applied/rebased onto the new upstream base before this bump can land).

Suggested next steps

  1. Check whether ltowarke/opentelemetry-cpp@767f797's exporters/otlp/CMakeLists.txt still gates the curl FetchContent/find_package(CURL) calls behind WITH_HTTP_CLIENT_CURL, and whether opentelemetry_http_client (PR #4071) is still present.
  2. If the patch was dropped during the fork sync, it needs to be re-applied on top of 767f797 in the fork repo before this submodule bump can be merged here.
  3. If it's just a renamed/additional CMake option, I can update CMakeLists.txt:93 accordingly — happy to do this once pointed at the relevant diff, or if git fetch/WebFetch access is enabled for this job.

Fix this →

@ltowarek

Copy link
Copy Markdown
Owner

Switched to upstream in #57

@ltowarek ltowarek closed this Jun 14, 2026
auto-merge was automatically disabled June 14, 2026 13:31

Pull request was closed

@dependabot @github

dependabot Bot commented on behalf of github Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/submodules/third_party/opentelemetry-cpp-e0c6c33 branch June 14, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant