Skip to content

Add support for mailgun variables - #203

Open
belidzs wants to merge 1 commit into
lukencode:masterfrom
belidzs:mailgun-variables
Open

Add support for mailgun variables#203
belidzs wants to merge 1 commit into
lukencode:masterfrom
belidzs:mailgun-variables

Conversation

@belidzs

@belidzsbelidzs commented May 25, 2020

Copy link
Copy Markdown
Contributor

Fixes#201

@belidzsbelidzs changed the title Add support for mailgun variables #201Add support for mailgun variablesMay 25, 2020
@lukencode

Copy link
Copy Markdown
Owner

Hi @belidzs and @klevisndoka I am going to find time in the next week to review all these PRs and get a new release going. Thanks heaps for your work (and sorry for the delay on my end)

@lukencode

Copy link
Copy Markdown
Owner

This is very similar to #204 . I suggested maybe a renderer is the best option (though we might have to change some core core)

@belidzs

Copy link
Copy Markdown
ContributorAuthor

@lukencode not really, these variables primarily serve as metadata, so using them in rendering is only a secondary thing.

For instance if a developer sends a notification about a new invoice generated in their application they can pass the invoice ID so when the message is delivered (and mailgun calls your configured web service as a result) it also includes these variables as easily processable variables.

@stefankip

Copy link
Copy Markdown

Too bad this has bled to death

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mailgun Recipient-Variables

4 participants

@belidzs@lukencode@stefankip@klevisndoka