Uh oh!
There was an error while loading. Please reload this page.
Unbound splat arguments, fixes GH-54 - #59
Open
amireh wants to merge 2 commits into
Open
Conversation
alerqueforce-pushed
the
unbounded-splats
branch
from
December 18, 2023 13:15
7638347 to
a968c90CompareBREAKING CHANGE: The default maxcount value for SPLAT arguments is now
unlimited. The previous default was 1. That was unexpected for many
folks and arguably wrong, but fixing it is a major breaking change and
consumers will need to adjust, hence the major version bump. The old
behaviour can be achieved by setting the maxcount to 1 again:
cli:splat('MY_SPLAT', 'Description', nil, 1)
Additionally a limit of 999 has been resolved so unlimited arguments can
be accepted.alerqueforce-pushed
the
unbounded-splats
branch
from
December 18, 2023 15:19
a968c90 to
2da9ecdCompareTieske
commented
Aug 11, 2026
Member
@amireh since we have a breaking change staged for release, we might as well add this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is a breaking change and requires a major release.
The patch makes it so that we no longer reject more than 999 repetitions
for a splat argument, and that by default we allow for unlimited
arguments (maxcount=0 or nil) instead of 1.