Uh oh!
There was an error while loading. Please reload this page.
Don't limit packet sizes to > 16 - #21
Merged
Merged
Conversation
Luxonis-Brandon
commented
May 5, 2020
Contributor
Thanks for finding/fixing. That's so strange! Do you have any idea why this was done previously? |
SzabolcsGergely
commented
May 5, 2020
ContributorAuthor
No. |
Luxonis-Brandon
commented
May 5, 2020
Contributor
That's what I was guessing. I'll run this through the paces today to make sure there aren't any weird unforeseen impacts. |
SzabolcsGergely
commented
May 9, 2020
ContributorAuthor
In the Intel mobilenet ssd example (we shipped RPI with that in the beginning) metaout wasn't used only for NN output, but for other "meta datas", with size 16, that's why the limit was added in our code, most likely. |
Luxonis-Brandon
commented
May 9, 2020
Contributor
Ah, got it, thanks! |
alex-luxonis
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packets with sizes larger than 16 were ignored, which broke some networks with output of just a few bytes.