Skip to content

deps: bump rt-client to activate dev-mode action commands - #9

Merged
m4ttheweric merged 1 commit into
mainfrom
feat/rt-devmode
Aug 30, 2026
Merged

deps: bump rt-client to activate dev-mode action commands#9
m4ttheweric merged 1 commit into
mainfrom
feat/rt-devmode

Conversation

@m4ttheweric

@m4tthewericm4ttheweric commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #7. Activates the action-command surface that shipped dormant.

Why

isDevMode() reads the rt setting mattstack.mode via @mattstack/rt-client's getSetting, but the pinned 0.3.0 does not register that key, and getSetting throws for unregistered keys. The gate therefore always fell closed to prod, leaving the board's per-command buttons, the /api/v1/apps/:name/commands/* routes, and deck cmd inert in real dev (the feature was correct and fully tested via injected devMode, just never activated).

0.10.1 registers mattstack.mode (string, machine-scoped, dev|prod), so the gate now works.

Safety of the jump (0.3.0 -> 0.10.1)

deck only uses getSetting / setSetting / rtCommand and the deck.apps / deck.access / deck.platform store keys. Diffed across the versions:

  • All three deck.* key definitions are byte-identical.
  • getSetting and rtCommand signatures unchanged; the only setSetting-file diff is a doc comment added above the neighboring unsetSetting.

So this is a pure activation, not an API migration.

Testing

  • Full unit suite bun test core src = 513 pass / 0 fail (was 512; +1 new test).
  • New regression test exercises the realgetSetting path under an isolated HOME (not the injected-read fakes the other dev-mode tests use): unset -> prod, mode=prod -> false, mode=dev -> true. Verified end to end that the dormancy is lifted.

No app code changed... only the version pin, lockfile, and the new test.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved reliability when detecting and applying development-mode settings.
    • Ensured production, development, and unset mode configurations behave consistently.
  • Tests

    • Added coverage for mode configuration scenarios, including isolated environment testing.

rt-client 0.3.0 did not register the `mattstack.mode` setting key, and
getSetting throws for unregistered keys, so isDevMode() always fell closed
to prod: the whole action-command surface (board buttons, /commands routes,
deck cmd) was dormant in real dev. 0.10.1 registers mattstack.mode (string,
machine-scoped, dev|prod). deck's rt-client surface (getSetting/setSetting/
rtCommand and the deck.apps/access/platform key defs) is byte-identical
across 0.3.0..0.10.1, so this is a pure activation with no API change.
Adds a regression test exercising the real getSetting path (unset/prod ->
false, dev -> true), which the existing injected-read tests bypass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce6e3fc5-e3e1-4929-bed1-56828e76b70a

📥 Commits

Reviewing files that changed from the base of the PR and between 195d9a2 and 8768cb5.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/api/dev-mode.test.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The pull request updates @mattstack/rt-client and adds regression coverage for mattstack.mode. The test uses an isolated home directory, resets cached state, checks production and development settings, and restores the environment.

Changes

Dev-mode configuration

Layer / File(s)Summary
Runtime client and regression test
package.json, src/api/dev-mode.test.ts
Updates @mattstack/rt-client from ^0.3.0 to ^0.10.1. Adds an isolated settings-store test for unset, "prod", and "dev" values, with cache resets and environment restoration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 8768c

The dependency update activates development-mode command functionality and adds regression coverage without changing application code; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the dependency update and its purpose: activating dev-mode action commands.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/rt-devmode

Comment @coderabbitai help to get the list of available commands.

@m4ttheweric

Copy link
Copy Markdown
CollaboratorAuthor

@coderabbitai review

@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@m4ttheweric
m4ttheweric merged commit f4eeef9 into mainAug 30, 2026
1 check passed
@m4ttheweric
m4ttheweric deleted the feat/rt-devmode branch August 30, 2026 02:55
m4ttheweric added a commit that referenced this pull request Aug 30, 2026
core/generated-fresh.test asserts a rebuild reproduces the committed bundle;
after the rt-client bump (#9) the committed artifact no longer matched a
fresh build, leaving main red. No board source changed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@m4ttheweric