Uh oh!
There was an error while loading. Please reload this page.
chat: wrap inbox deliveries in the cross-session envelope - #131
Merged
Conversation
…ed rendering Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughChat delivery now wraps room, DM, batched, and welcome content in labeled ChangesChat delivery formatting
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Claude Code's terminal renders an inbound peer message as a collapsed one-line row only when the content opens with its
<cross-session-message ...>envelope; bare text renders in full. rt's socket deliveries sent bare text, so every chat message and welcome frame dumped its whole body (plus the harness's safety boilerplate) into the recipient's terminal view.How
lib/daemon/inbox.ts:wrapCrossSession(label, body)builds the exact envelope (from-nameonly; nofrom, which is a SendMessage reply address rt recipients must not use);deliveryLabel(items)names the sender for a single message (kai (#rt)/kai (dm)) and counts a batch (rt chat (3 messages)).lib/daemon/handlers/chat.ts: deliverPost and the sign-in welcome wrap at the delivery seam; render helpers stay pure.skills/rt-chat/SKILL.md: the delivery format section shows the envelope and warns thatfrom-nameis a label, not a reply address.Presentation only: the model still receives the full body, and these messages were already framed as peer input.
Tests
3 new unit tests (envelope shape, label attr-escaping, label selection); delivery assertions updated across unit + e2e. Unit suite green; e2e
chat-inbox-delivery2/2 against a real daemon and socket.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation