chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(upstream): sync marcode through pingdotgg/t3code@beab6886 - #43

Closed
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl
Closed

chore(upstream): sync marcode through pingdotgg/t3code@beab6886#43
maarco wants to merge 46 commits into
mainfrom
claude/gracious-bohr-b96qvl

Conversation

@maarco

@maarcomaarco commented Aug 20, 2026

Copy link
Copy Markdown
Owner

What Changed

Merges 44 upstream commits from pingdotgg/t3code@beab6886 into Marcode's main. Compare: main...claude/gracious-bohr-b96qvl

Conflict decisions (17 conflicted files):

  • apps/server/src/cli/connect.ts, service.ts — adopt upstream's macOS-vs-Linux boot-service branching, keep Marcode branding in every user-facing string.
  • apps/web/src/components/ChatView.tsx — keep Marcode's minimal ChatHeader (thread actions portal into FloatingPillNav) but close with the upstream <WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell while adopting upstream's chat-composer-glass-shell-attached state.
  • apps/web/src/components/RightPanelTabs.tsx — adopt upstream's browser-tab mute feature (Volume icons, previewBridge, toggle-mute item and handler) and its data-driven addSurfaceActions.map render. Retire the Files action and copy-path menu entry — Marcode has no right-panel file surface. PierreEntryIcon import dropped for the same reason.
  • apps/web/src/components/ThreadTerminalDrawer.tsx — keep Marcode's TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm fork) but adopt upstream's confirm-before-close on every close call site.
  • apps/web/src/components/chat/ChatComposer.tsx — keep Marcode's floating glass surface (hotspot) with its focus/blur/drag machinery.
  • apps/web/src/components/chat/ChatHeader.tsx — keep Marcode's minimal ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery belongs on the chat title, which Marcode does not render here (portalled to FloatingPillNav, entry point on the sidebar row's context menu).
  • apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx — keep Marcode's PENDING APPROVAL card layout; honor the new className prop from upstream. Test rewritten to pin the card design so a future sync fails loudly if the compact-row shape reappears.
  • apps/web/src/components/pullRequest/PullRequestListFilters.tsx — keep Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
  • apps/web/src/routes/_chat.pull-requests.tsx — adopt upstream's extracted PullRequestRefreshControl (removes Marcode's duplicate inline refresh button); add the Tooltip on the extracted control so the label is preserved on both call sites.
  • apps/web/src/routes/settings.tsx and apps/web/src/components/usage/UsagePage.tsx — take upstream's content changes (settings breadcrumb cluster, the usage insights redesign and its topbarContent), but keep Marcode's own two-branch page header shell rather than upstream's extracted <WorkspacePageHeader>. Upstream hardcodes that component's inset to COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a data-sidebar-state=collapsed ancestor; Marcode renders no sidebar on these two routes, so the inset never applies and on Electron the breadcrumb slides under the macOS traffic lights. The electron branch keeps SIDEBARLESS_TITLEBAR_INSET_CLASS, the invariant pinned by workspaceTitlebar.fork.test. UsagePage also keeps Marcode's tooltip on every Refresh button.
  • apps/web/src/routes/__root.tsx — keep both DraftPromotionWatcher (Marcode) and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
  • apps/web/src/components/sidebar/SidebarChrome.tsx — keep Marcode's brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays minimal and SidebarChromeFooter still shows only the update pills. Export upstream's new SidebarUtilityMenu — the Settings sidebar (SettingsSidebarNav) needs it — but do not mount it on the workspace footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
  • packages/client-runtime/src/state/threadSettled.ts — adopt upstream's fix that only auto-settles once per merged/closed PR (thread-latest-event check), and layer Marcode's 1h idle guard on top so a warm follow-up conversation is not buried the instant the PR merges. Tests updated for the renamed changeRequest field.
  • apps/web/src/components/files/*Panel.tsx (modify/delete) — Marcode has no right-panel file surface; keep deleted.

Fork-boundary breaks that merged cleanly and are also fixed here:

  • apps/server/src/cloud/bootService.ts — the launchd plist declared T3CODE_HOME but Marcode's launcher requires MARCODE_HOME (service would fail to boot on macOS). Renamed and pinned by a new test in bootService.test.ts. Also updated the stale test assertion that expected systemctl --user disable --now t3code.service — Marcode's systemd unit is marcode.service.
  • apps/server/src/cli/triage.tst3 triage read T3CODE_HOME; renamed to MARCODE_HOME to match Marcode's launcher and t3 pair.
  • apps/desktop/scripts/electron-launcher.mjs — dev launcher exported T3CODE_* env vars but DesktopConfig reads MARCODE_* (the desktop app would not pick up the overrides). Renamed here and in the test.

Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions, @effect/* unchanged, infra/relay/package.json unchanged; no vendored subtree resync needed.

Why

Daily upstream sync per .github/upstream-sync.yml. This picks up 44 upstream commits including the browser-tab mute feature, macOS launchd boot service, the usage insights redesign, feat(threads): a merged PR settles its thread only once, and many fix(*) correctness/security changes. Hotspots reviewed against the customization map; where upstream touched Marcode-owned files, decisions are recorded above.

UI Changes

Only visible client changes shipped by upstream. Marcode-owned hotspots (floating pill nav, unified sidebar, floating editor, glass composer, PENDING APPROVAL card, sidebarless settings/usage titlebars) render unchanged. No screenshots attached: the touched surfaces either reuse upstream widgets that upstream's own tests exercise, or preserve Marcode's shape verbatim under focused tests. Worth a human eye on the desktop build for the redesigned usage page and the settings header, since those two are where upstream's layout refactor met Marcode's titlebar invariant.

Checklist

  • This PR is small and focused — it is one upstream sync; scope is exactly the upstream delta plus fork-boundary repairs.
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — deferred to human review of the desktop build
  • I included a video for animation/interaction changes — n/a

Verification

CI on e457a94: Check ✅ · Test ✅ · Mobile Native Static Analysis ✅ · Release Smoke ✅ — all four required checks green. Thread transfer budget within every enforced ceiling.

The first push (a207bdf) failed Test on workspaceTitlebar.fork.test.ts: I had over-adopted upstream's WorkspacePageHeader on settings and usage, dropping Marcode's sidebarless titlebar inset. Fixed in e457a94 — see the settings/usage entry above. The fork test caught exactly the class of silent regression it exists for.

Focused local verification, all passing:

  • packages/client-runtime/src/state/threadSettled.test.ts (193)
  • apps/server/src/cloud/bootService.test.ts, apps/server/src/serviceLauncher.test.ts, apps/desktop/scripts/electron-launcher.test.mjs (30)
  • apps/server/src/cli/service.test.ts, apps/server/src/cli/config.test.ts (11)
  • apps/server/src/cli/triagePrompt.test.ts (4)
  • apps/web/src/components/chat/ChatHeader.test.ts, ComposerPendingApprovalPanel.test.tsx, ComposerPendingApprovalActions.test.tsx, pullRequest/PullRequestListFilters.test.tsx, RightPanelTabs.test.tsx (33)
  • apps/web/src/components/sidebar/SidebarChrome.fork.test.tsx, threadSidebarWidth.test.ts, threadActionMenu.logic.test.ts, workspaceTitlebar.fork.test.ts (18)
  • tsgo typecheck across t3, @t3tools/web, @t3tools/desktop, @t3tools/client-runtime — clean
  • vp fmt --check + vp lint across all changed paths — clean

Left as a draft for review, per the upstream-sync policy.

aorightand others added 30 commits August 18, 2026 13:38
…in GitHubPullRequestCli (pingdotgg#7385)
Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
…t full speed (pingdotgg#7460)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…nt (pingdotgg#6563)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#6286)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
maria-rcksand others added 15 commits August 19, 2026 16:09
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Merges 44 upstream commits from pingdotgg/t3code@beab6886. Conflict decisions:
- apps/server/src/cli/connect.ts, service.ts: adopt upstream's macOS-vs-Linux
boot-service branching, keep Marcode branding in every user-facing string.
- apps/web/src/components/ChatView.tsx: keep Marcode's minimal ChatHeader
(thread actions portal into FloatingPillNav) but close with the upstream
<WorkspacePageHeader> tag; keep Marcode's transparent glass composer shell
while adopting upstream's chat-composer-glass-shell-attached state.
- apps/web/src/components/RightPanelTabs.tsx: adopt upstream's browser-tab
mute feature (Volume icons, previewBridge, toggle-mute item and handler)
and its data-driven addSurfaceActions.map render. Retire the Files action
and copy-path menu entry — Marcode has no right-panel file surface.
PierreEntryIcon import dropped for the same reason.
- apps/web/src/components/ThreadTerminalDrawer.tsx: keep Marcode's
TerminalPlacementSlot + TerminalChromeActions chrome (owns its own xterm
fork) but adopt upstream's confirm-before-close on every close call site.
- apps/web/src/components/chat/ChatComposer.tsx: keep Marcode's floating
glass surface (hotspot) with its focus/blur/drag machinery.
- apps/web/src/components/chat/ChatHeader.tsx: keep Marcode's minimal
ThreadActionsCluster; upstream's new inline-rename/thread-menu machinery
belongs on the chat title, which Marcode does not render here (portalled
to FloatingPillNav, entry point on the sidebar row's context menu).
- apps/web/src/components/chat/ComposerPendingApprovalPanel.tsx: keep
Marcode's PENDING APPROVAL card layout; honor the new className prop from
upstream. Test rewritten to pin the card design so a future sync fails
loudly if the compact-row shape reappears.
- apps/web/src/components/pullRequest/PullRequestListFilters.tsx: keep
Marcode's Tooltip-wrapped MenuTrigger for the filter icon.
- apps/web/src/routes/_chat.pull-requests.tsx: adopt upstream's extracted
PullRequestRefreshControl (removes Marcode's duplicate inline refresh
button); add the Tooltip on the extracted control so the label is
preserved on both call sites.
- apps/web/src/routes/settings.tsx: adopt upstream's WorkspacePageHeader
refactor. Drop the now-unused inset-class imports.
- apps/web/src/routes/__root.tsx: keep both DraftPromotionWatcher (Marcode)
and upstream's new PlanAgentSelectionHeal, mounted side-by-side.
- apps/web/src/components/sidebar/SidebarChrome.tsx: keep Marcode's
brand/navigation-in-FloatingPillNav invariant; SidebarChromeHeader stays
minimal and SidebarChromeFooter still shows only the update pills.
Export upstream's new SidebarUtilityMenu — the Settings sidebar
(SettingsSidebarNav) needs it — but do not mount it on the workspace
footer. Sidebar brand/wordmark are pinned out by threadSidebarWidth.test.
- apps/web/src/components/usage/UsagePage.tsx: adopt upstream's usage
insights redesign wholesale, then re-add Marcode's tooltip on every
Refresh button.
- packages/client-runtime/src/state/threadSettled.ts: adopt upstream's fix
that only auto-settles once per merged/closed PR (thread-latest-event
check), and layer Marcode's 1h idle guard on top so a warm follow-up
conversation is not buried the instant the PR merges. Tests updated for
the renamed changeRequest field.
- Retire apps/web/src/components/files/*Panel.tsx (modify/delete): Marcode
has no right-panel file surface; keep deleted.
Fork-boundary breaks that merged cleanly and are fixed in this commit:
- apps/server/src/cloud/bootService.ts: the launchd plist declared
T3CODE_HOME but Marcode's launcher requires MARCODE_HOME — service
would fail to boot on macOS. Renamed and pinned by a new test in
bootService.test.ts. Also updated the stale test assertion that
expected systemctl --user disable --now t3code.service — Marcode's
systemd unit is marcode.service.
- apps/server/src/cli/triage.ts: t3 triage read T3CODE_HOME; renamed
to MARCODE_HOME to match Marcode's launcher and t3 pair.
- apps/desktop/scripts/electron-launcher.mjs: dev launcher exported
T3CODE_* env vars but DesktopConfig reads MARCODE_* — the desktop
app would not pick up the overrides. Renamed here and in the test.
Coupled subtree check: pnpm-workspace.yaml only moved Clerk versions,
@effect/* unchanged, infra/relay/package.json unchanged; no vendored
subtree resync needed.
Focused verification (all passed): threadSettled (193), bootService +
serviceLauncher + electron-launcher (30), CLI service + config (11),
triagePrompt (4), ChatHeader (8), ComposerPendingApprovalPanel (3),
RightPanelTabs + PullRequestListFilters + related (33), sidebar/thread
fork tests (17); tsgo typecheck across t3, web, desktop, client-runtime;
vp fmt --check + vp lint across all changed paths — clean.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 20, 2026
@github-actions

github-actionsBot commented Aug 20, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire12.6 KiB13.4 KiB+833 B (+6.5%)15.1 KiB
CodexThread snapshot wire6.3 KiB6.9 KiB+616 B (+9.6%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.5 KiB+217 B (+3.4%)7.8 KiB
CodexLive turn WebSocket decoded51.8 KiB55.0 KiB+3.2 KiB (+6.1%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire12.6 KiB13.4 KiB+864 B (+6.7%)15.1 KiB
ClaudeThread snapshot wire6.3 KiB6.9 KiB+636 B (+9.9%)7.3 KiB
ClaudeLive turn WebSocket wire6.3 KiB6.5 KiB+228 B (+3.5%)7.8 KiB
ClaudeLive turn WebSocket decoded52.7 KiB55.8 KiB+3.2 KiB (+6.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 2ffb140 · PR result: e457a94 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Upstream extracted <WorkspacePageHeader> and hardcoded its inset to
COLLAPSED_SIDEBAR_TITLEBAR_INSET_CLASS, which keys off a
`data-sidebar-state=collapsed` ancestor. Marcode's settings and usage
routes render no sidebar, so that ancestor never exists — the inset does
not apply and, on Electron, the breadcrumb sits under the macOS traffic
lights.
Restore Marcode's explicit two-branch header (non-electron + electron
drag-region) with SIDEBARLESS_TITLEBAR_INSET_CLASS on the electron
branch, matching the invariant pinned by workspaceTitlebar.fork.test.
Both files still consume the merged content — settings' breadcrumb
cluster and UsagePage's topbarContent — just inside Marcode's own
header shell.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaxM2AZZQ3BiqR2Gb1w2YW
@maarcoChatGPT Codex Connector

Copy link
Copy Markdown
OwnerAuthor

Superseded by PR #51, the newer upstream sync through f035a0f4, which has now merged to main. Closing this older draft to keep the sync queue clean.

@maarcomaarco closed this Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@maarco@aoright@gbarros-dev@Bil0000@Rishet11@StiensWout@AugusDogus@tarik02@gsimone@t3dotgg@chrisdeeming@inayayousfi@RakshithBhat03@dbalders@maria-rcks@UtkarshUsername@SunkenInTime@lgwacker@jakeleventhal@claude