Skip to content

Symfony 8 support - #63

Open
olegpro wants to merge 1 commit into
mac-cain13:masterfrom
olegpro:symfony8
Open

Symfony 8 support#63
olegpro wants to merge 1 commit into
mac-cain13:masterfrom
olegpro:symfony8

Conversation

@olegpro

Copy link
Copy Markdown
Contributor

No description provided.

@olegpro

Copy link
Copy Markdown
ContributorAuthor

@mac-cain13 review pls

@pieterocp

pieterocp commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Since working on the issue and seeing a local CI failure, there's a failing test in symfony:^8.0

See: https://github.com/symfony/symfony/blob/8.1/UPGRADE-8.0.md#console

Remove deprecated Symfony\Component\Console\Application::add() method in favor of Symfony\Component\Console\Application::addCommand()

The rest of the application is probably fine though.

Throwing to the test tests/Wrep/Daemonizable/Command/EndlessCommandRunloopTest.php:22 something like the below would work to keep the tests working.

- $application->add($command);
+ if (method_exists($application, 'add')) {
+ $application->add($command);
+ } elseif (method_exists($application, 'addCommand')) {
+ $application->addCommand($command);
+ } else {
+ thrownew \LogicException('check symfony docs since both are gone.');
+ }

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@olegpro@pieterocp