Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Operations: transform CloneOperation back to simple static method - #75

Open
antis81 wants to merge 1 commit into
developmentfrom
ngf/operations/clone
Open

Operations: transform CloneOperation back to simple static method#75
antis81 wants to merge 1 commit into
developmentfrom
ngf/operations/clone

Conversation

@antis81

Copy link
Copy Markdown
Member

@scunz Can you please review and confirm, that this matches your imagination? If so, I'll go on transforming the former CloneOperation, preparing it for our planned MGV-Service.

Things to do after the above is confirmed:

  • transport the callbacks from Git::CloneOperation
  • abstract git_clone_options to public Git::CloneOptions, making them available to the public API
    • Roughly spoken, the former Git::CloneOperation::setSomeCloneOption methods have to be extracted into a new public Git::CloneOptions class or struct.

@antis81

Copy link
Copy Markdown
MemberAuthor

@scunz Does this match to what you have in mind concerning the "service infrastructure"?

@scunz

Copy link
Copy Markdown
Member

Yes, just running the clone without any threading is fine.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@antis81@scunz