Uh oh!
There was an error while loading. Please reload this page.
Use Pygithub object instead of url_request - #29
Merged
Conversation
stefanv
commented
Apr 17, 2018
Contributor
Teddy, is this good to go? I see conflicts, and also it looks like you committed your key. |
ttran428
commented
Apr 17, 2018
ContributorAuthor
I deleted my key(I forgot to commit that change last time I think) and I fixed the conflicts by merging the upstream into my branch. |
stefanv
commented
Apr 17, 2018
Contributor
You now have After removing, please ask @SeraYang1 to review and merge if she's happy. |
ttran428
commented
Apr 17, 2018
ContributorAuthor
sounds good. I will ask her. |
SeraYang1
approved these changes
Apr 18, 2018
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 19, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 19, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 19, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 19, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 19, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
SeraYang1 added a commit
to SeraYang1/oss_devkit
that referenced
this pull request
Apr 20, 2018
* upstream/master: General cleanup (machine-shop#38) Use Pygithub object instead of url_request (machine-shop#29)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the functions find_pr_info and find_issues_info to use the github object instead to increase api calls.