Skip to content

<C-U> and <C-O> don't work when using Japanese IM with "Windows-like shortcuts" turned on - #742

Merged
splhack merged 1 commit into
macvim-dev:masterfrom
ichizok:fix/windows-like-shortcuts
Sep 22, 2018
Merged

<C-U> and <C-O> don't work when using Japanese IM with "Windows-like shortcuts" turned on#742
splhack merged 1 commit into
macvim-dev:masterfrom
ichizok:fix/windows-like-shortcuts

Conversation

@ichizok

Copy link
Copy Markdown
Member

Maybe this is Japanese IM bug, this PR is a workaround for the problem.

Changes:

  • Don't call interpretKeyEvents (i.e. don't send key-event to IM) when no marked text and with only control-modifier (and shift-modifier)

Refs:
https://stackoverflow.com/questions/29712392/ctrl-u-doesnt-work-in-macvim
https://qiita.com/furu8ma/items/7e421da98680d1c4c0f8
http://gpsoft.dip.jp/hiki/?Yosemite%2FMacVimでトラブル

@ichizok

Copy link
Copy Markdown
MemberAuthor

NOTE I haven't confirmed on other IMs, there might be some problem.

@ichizok
ichizokforce-pushed the fix/windows-like-shortcuts branch from a355d28 to 221664cCompareSeptember 12, 2018 22:59
@ichizok
ichizokforce-pushed the fix/windows-like-shortcuts branch from 221664c to d9c3c62CompareSeptember 20, 2018 07:25
@splhack
splhack merged commit a968ddf into macvim-dev:masterSep 22, 2018
@ichizok
ichizok deleted the fix/windows-like-shortcuts branch September 22, 2018 09:09
ychin added a commit to ychin/macvim that referenced this pull request Dec 5, 2018
Vim patch 8.1.560
Targets macOS 10.8+
Features:
- macOS Mojave (10.14) is now supported.
- MacVim's UI now works with Dark Mode.
- Fixed broken rendering and flickering under Mojave when using the
default Core Text renderer. macvim-dev#757
- guioption 'k' is supported again. macvim-dev#731
- This option prevents window from resizing when UI elements such as
toolbars or tabs show or hide themselves.
Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts macvim-dev#745
- Dragging tabs to reorder now works properly macvim-dev#789
- Fixed timer callback handling in GUI macvim-dev#749
- Fixed native tabs (10.12+) interring with Vim tabs macvim-dev#788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling macvim-dev#742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions macvim-dev#780
- Better handling of guifontwide font size macvim-dev#737
- Better python discovery in default vimrc macvim-dev#739
Known Issues:
- Scrolling performance is slightly worse under Mojave macvim-dev#796
Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
ychin added a commit that referenced this pull request Dec 5, 2018
Vim patch 8.1.560
Targets macOS 10.8+
Features:
- macOS Mojave (10.14) is now supported.
- MacVim's UI now works with Dark Mode.
- Fixed broken rendering and flickering under Mojave when using the
default Core Text renderer. #757
- guioption 'k' is supported again. #731
- This option prevents window from resizing when UI elements such as
toolbars or tabs show or hide themselves.
Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts #745
- Dragging tabs to reorder now works properly #789
- Fixed timer callback handling in GUI #749
- Fixed native tabs (10.12+) interring with Vim tabs #788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling #742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions #780
- Better handling of guifontwide font size #737
- Better python discovery in default vimrc #739
Known Issues:
- Scrolling performance is slightly worse under Mojave #796
Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ichizok@splhack