Skip to content

add nashdoc tool - #175

Open
i4ki wants to merge 2 commits into
masterfrom
add-nashdoc
Open

add nashdoc tool#175
i4ki wants to merge 2 commits into
masterfrom
add-nashdoc

Conversation

@i4ki

@i4kii4ki commented Feb 17, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Tiago <tiago.natel@neoway.com.br>

@katcipiskatcipis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool do add some docs on this. But to be honest I was hoping to get the whole documentation thing for nash working properly before, things are kinda README/messy right now.

Comment threadcmd/nashdoc/doc.go
fmt.Println()
}

func lookFn(stdout, stderr io.Writer, fname string, pack string, pattern *regexp.Regexp) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just the first parameters omits type ?

"testing"
)

type (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one type inside type() ? Some reason for this ? consistency ?

}

func TestDoc(t *testing.T) {
for _, test := range []testTbl{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show struct initialization with the field names some love :-), again kind'a hard to understand what is each of the fields.

Comment threadcmd/nashdoc/idoc.go
"regexp"
)

const banner = `888b 888 888 888 888888

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAWWEESOMEEEEEEEE !!! lol


}

# carrr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One a lisper always a lisper :-P

@i4ki

i4ki commented Feb 18, 2017

Copy link
Copy Markdown
CollaboratorAuthor

Sorry about this code...

I just found this old branch on my computer and then I pushed it to remember to improve it...
Thanks for the review. I'll try to improve it soon.

@katcipis

Copy link
Copy Markdown
Member

Sorry to not be helping with more code yet, but I'm starting to hang around more, taking a look at the internal/sh package right now :-)

@ryukinix

Copy link
Copy Markdown
Member

nashdoc seems a nice thing. There is still some interesting in working on that?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@i4ki@katcipis@ryukinix