Skip to content

Update Resume matcher - #21

Merged
AmirAref merged 8 commits into
masterfrom
update-matcher
Jun 10, 2026
Merged

Update Resume matcher#21
AmirAref merged 8 commits into
masterfrom
update-matcher

Conversation

@AmirAref

Copy link
Copy Markdown
Contributor

No description provided.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Resume Matcher (Score)” client to reflect a significantly expanded resume-score response schema, adds client-side validation for job_description length, and updates tests/docs accordingly (including removing external HTTP dependencies from several tests).

Changes:

  • Expand ResumeScoreResponse / resume-score types to a richer nested schema (strengths/improvements + job/skill/education match breakdowns).
  • Add job_description length validation (100–5000 chars) in ResumeScoreService.get_resume_score() and adjust smoke/tests.
  • Improve test reliability by switching several service tests to httpx.MockTransport and adding new unit tests for the resume-score service.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file
FileDescription
tox.iniFix GitHub Actions tox environment mapping by adding the python = key.
pyproject.tomlBump package version to 1.6.0.
README.mdRename/clarify supported API names for “Resume Checker(Review)” and “Resume Matcher(Score)”.
magicalapi/types/resume_score.pyReplace the old resume-score schema with a detailed nested response model.
magicalapi/services/resume_score_service.pyAdd job_description length validation and update service wording.
tests/types/test_resume_score_type.pyUpdate type-validation tests to match the new resume-score schema.
tests/services/test_resume_score_service.pyAdd new tests covering job_description length validation and response parsing.
tests/services/test_webhook_url.pyMake webhook-url tests hermetic via httpx.MockTransport (no external httpbin).
tests/services/test_base_service.pyMake base-service tests hermetic via httpx.MockTransport and update resume-score validation fixture payload.
smoke/test_smoke.pyUpdate smoke test input so job_description meets the new length requirements.
magicalapi/types/resume_review.pyUpdate service naming in module docstring.
magicalapi/types/profile_data.pyUpdate service naming in class docstring.
magicalapi/types/company_data.pyUpdate service naming in class docstring.
magicalapi/services/resume_review_service.pyUpdate service naming in module/method docstrings.
magicalapi/services/profile_data_service.pyUpdate service naming and normalize # type: ignore comment formatting.
magicalapi/services/company_data_service.pyUpdate service naming in module/method docstrings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadmagicalapi/types/resume_score.py Outdated
Comment threadmagicalapi/types/resume_score.py Outdated
Comment on lines +38 to +41
if not 100 <= len(job_description) <= 5000:
raise ValueError(
"job_description must be between 100 and 5000 characters long"
)
Comment threadtests/services/test_resume_score_service.py
service = ResumeScoreService(httpxclient)
captured_request: dict[str, str] = {}

async def fake_send_post_request(path: str, data: dict[str, str], headers: dict[str, str] = {}):
@AmirAref
AmirAref merged commit d8322f9 into masterJun 10, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AmirAref