Skip to content

Repository files navigation

react-native-textinput-clear

Test app for react-native TextInput bugfix.

This is a test app for the pull request for react-native.

react-native 0.54.0 has a bug which textInputRef.setNativeProps({text: ''}) doesn't work.

You can check if the pull request fixes the bug.

Issues

[0.54] TextInput.setNativeProps({text: ''}) no longer works (#18272)

TextInput value not binding on IOS (#18389)

Pull Request

[iOS][TextInput] Fix #18272 TextInput.setNativeProps({text: ''}) to work (#18278)

Build and Run

Build with Bugfix

git clone https://github.com/magicien/react-native-textinput-clear.git
cd react-native-textinput-clear
yarn install
react-native run-ios

If react-native run-ios command ends up with error, compile with Xcode.

Build with react 0.54.0 (which has the bug)

git clone -b test/react-0.54.0 https://github.com/magicien/react-native-textinput-clear.git
cd react-native-textinput-clear
yarn install
react-native run-ios

If react-native run-ios command ends up with error, compile with Xcode.

Test

clear()

  1. Tap clear button
    • The TextInput should become empty
  2. Put some text in the TextInput
  3. Tap clear button
    • The TextInput should become empty
    • It doesn't become empty with react 0.54.0

setNativeProps({text: '****'})

  1. Tap clear button
    • The TextInput should become empty
  2. Tap reset button
    • The TextInput should change
  3. Change the text in the TextInput by keyboard
  4. Tap reset button
    • The TextInput should change
    • It doesn't change with react 0.54.0

value prop

  1. Try to edit the TextInput at "Singleline with value"

The text should not be changed

attributed text (Thank you @reyalpsirc!)

  1. Move the slider at "Attribute"

It should keep the font style (font family, size, color, text align)

Result

react 0.54.0

  • clear() doen't work from the second time
  • setNativeProps({text '***'}) doesn't work from the second time

ScreenShot_0.54.0

with Bugfix

  • clear() works every time
  • setNativeProps({text '****'}) works every time

Singleline

ScreenShot_Clear_1

Multiline

ScreenShot_Clear_2

Attributed text test with Bugfix

ScreenShot_Slider

value prop with Bugfix

ScreenShot_Value

Other behaviors

onChange / onChangeText callback

onChange / onChangeText won't be called when setNativeProps({text: ''}) is called.

This is the same as react 0.53.0.

set non-string values

When non-string values are given to setNativeProps({text: ___}), its behavior is the same as react 0.53.0.

Value TypeResult
nullsame as empty string ''
undefinednothing changes
numberthrow error
functionthrow error
objectthrow error

About

Test app for react-native TextInput bugfix

Topics

Resources

Stars

0 stars

Watchers

1 watching

Forks

Releases

Packages

Contributors

Languages