Uh oh!
There was an error while loading. Please reload this page.
overwrite vars - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for overriding YAML collection variables from the CLI via a repeatable --var KEY=VALUE flag, allowing users to override or inject variables when running wave -c ... collection requests.
Changes:
- Introduced
extract_var_overridesto parse and strip--vararguments from trailing params and return a key/value override map. - Applied CLI variable overrides on top of collection
variables:duringhandle_collection, and rejected--varon non-collection commands. - Extended CLI error types and README documentation to describe the new behavior and usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib.rs | Implements parsing of --var overrides, applies overrides to collection vars, rejects --var for non-collection requests, and adds tests. |
| src/error.rs | Adds InvalidVarOverride and corresponding display/suggestion text. |
| README.md | Documents --var usage for collection variable overrides/injection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1116
to
+1117
| let dir = std::env::temp_dir().join(format!("wave_var_test_{}", std::process::id())); | ||
| let wave_dir = dir.join(".wave"); |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.