Skip to content

chore: drop unused serviceaccount issuer config for removed www oidc endpoint - #18

Merged
xnoto merged 1 commit into
mainfrom
chore/drop-unused-sa-issuer
Aug 25, 2026
Merged

chore: drop unused serviceaccount issuer config for removed www oidc endpoint#18
xnoto merged 1 commit into
mainfrom
chore/drop-unused-sa-issuer

Conversation

@xnoto

Copy link
Copy Markdown
Contributor

The service-account-issuer.yaml block pointed k3s at the www-hosted static OIDC issuer (https://makeitwork.cloud/oidc) for the unbuilt AWS STS web-identity design. The endpoint had zero consumers and is being removed from www.

No live impact: cloud-init applies only at VM provision time, so the running k3s VM is untouched; and the apiserver validates ServiceAccount tokens with its local key, so even future provisions behave identically (k3s default issuer) without this block.

@xnoto
xnoto requested a review from a team as a code ownerAugust 25, 2026 18:12
@github-actions

Copy link
Copy Markdown

OpenTofu Plan

OpenTofu will perform the following actions:
# module.k3s.libvirt_cloudinit_disk.commoninit will be created
+ resource "libvirt_cloudinit_disk" "commoninit" {
+ id = (known after apply)
+ meta_data = <<-EOT
instance-id: k3s
local-hostname: k3s
EOT
+ name = "k3s_commoninit"
+ network_config = <<-EOT
version: 2
ethernets:
enp1s0:
dhcp4: true
enp2s0:
dhcp4: false
addresses:
- 192.168.102.2/24
EOT
+ path = (known after apply)
+ size = (known after apply)
+ user_data = (sensitive value)
}
# module.k3s.libvirt_volume.cloudinit will be replaced due to changes in replace_triggered_by
-/+ resource "libvirt_volume" "cloudinit" {
~ allocation = 53248 -> (known after apply)
~ capacity = 51200 -> (known after apply)
~ create = {
~ content = {
~ url = "/tmp/terraform-provider-libvirt-cloudinit/cloudinit-37580b1433857f71.iso" -> (known after apply)
}
}
~ id = "/mnt/nvme/cluster/k3s_cloudinit.iso" -> (known after apply)
~ key = "/mnt/nvme/cluster/k3s_cloudinit.iso" -> (known after apply)
name = "k3s_cloudinit.iso"
~ path = "/mnt/nvme/cluster/k3s_cloudinit.iso" -> (known after apply)
~ physical = 51200 -> (known after apply)
# (1 unchanged attribute hidden)
}
# module.k3s.terraform_data.cloudinit_content will be updated in-place
~ resource "terraform_data" "cloudinit_content" {
id = "5b88fd98-5e5c-89c7-2a69-42d8bf7cdce2"
~ input = (sensitive value)
~ output = "eb89fa5b06b758b3b8deea30afe6485f237877e320b197023532cf5a35f17c6c" -> (known after apply)
}
# module.runner.libvirt_cloudinit_disk.commoninit will be created
+ resource "libvirt_cloudinit_disk" "commoninit" {
+ id = (known after apply)
+ meta_data = <<-EOT
instance-id: runner
local-hostname: runner
EOT
+ name = "runner_commoninit"
+ network_config = (sensitive value)
+ path = (known after apply)
+ size = (known after apply)
+ user_data = (sensitive value)
}
Plan: 3 to add, 1 to change, 1 to destroy.

@xnoto
xnoto merged commit cb0cc00 into mainAug 25, 2026
4 checks passed
@xnoto
xnoto deleted the chore/drop-unused-sa-issuer branch August 25, 2026 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@xnoto