Uh oh!
There was an error while loading. Please reload this page.
chore: remove unused static oidc issuer endpoint - #17
Merged
Conversation
The endpoint served an empty keyset since creation and had zero consumers: no AWS IAM OIDC provider exists for it, no operator is wired to it, and the k3s apiserver validates ServiceAccount tokens with its local key. The AWS STS web-identity design it was scaffolded for was never built. Deploy with --delete removes it from the live site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
makeitwork.cloud/oidc/(discovery doc, index, empty JWKS) and its README section.Validation before removal:
token.actions.githubusercontent.com); nomakeitwork.cloudprovider was ever created{"keys": []}) the whole time and the org is fully functional — the k3s apiserver validates SA tokens with its local key; nothing external validates against this URLDeploy uses
aws s3 sync --delete, so the path is removed from the live site on merge. k3s cloud-init reference cleanup is a separate tfroot-libvirt PR (affects only future provisions).